Skip to content

Comments

refactor(parser): use function instead of trait to parse delimited lists#4014

Merged
Boshen merged 1 commit intomainfrom
07-02-refactor_parser_use_function_instead_of_trait_to_parse_delimited_lists
Jul 2, 2024
Merged

refactor(parser): use function instead of trait to parse delimited lists#4014
Boshen merged 1 commit intomainfrom
07-02-refactor_parser_use_function_instead_of_trait_to_parse_delimited_lists

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 2, 2024

relates #3887

The rest of the list parsing trait implementations involves ... parsing rest, which I'll refactor in another PR.

@github-actions github-actions bot added the A-parser Area - Parser label Jul 2, 2024
@Boshen Boshen force-pushed the 07-02-refactor_parser_use_function_instead_of_trait_to_parse_delimited_lists branch from 4f997b4 to aa30245 Compare July 2, 2024 06:42
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 2, 2024

CodSpeed Performance Report

Merging #4014 will not alter performance

Comparing 07-02-refactor_parser_use_function_instead_of_trait_to_parse_delimited_lists (aa30245) with main (e2c9015)

Summary

✅ 28 untouched benchmarks

@Boshen Boshen merged commit 1dacb1f into main Jul 2, 2024
@Boshen Boshen deleted the 07-02-refactor_parser_use_function_instead_of_trait_to_parse_delimited_lists branch July 2, 2024 06:47
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Boshen added a commit that referenced this pull request Jul 5, 2024
## [0.17.0] - 2024-07-05

- e32b4bc ast: [**BREAKING**] Store trivia comments in a sorted slice
(#4045) (Luca Bruno)

- 1df6ac0 ast: [**BREAKING**] Rename `visit_enum_memeber` to
`visit_ts_enum_member`. (#4000) (rzvxa)

- 4a0eaa0 ast: [**BREAKING**] Rename `visit_enum` to
`visit_ts_enum_declaration`. (#3998) (rzvxa)

- c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to
`visit_arrow_function_expression`. (#3995) (rzvxa)

### Features

- 1854a52 ast_codegen: Introduce the `#[span]` hint. (#4012) (rzvxa)
- 7538af1 ast_codegen: Add visit generator (#3954) (rzvxa)
- 7768d23 isolated-declarations: Support optional class methods (#4035)
(Egor Blinov)
- 0da9dfb minifier: Add constant folding to remove dead code (#4058)
(Boshen)

### Bug Fixes

- aaac2d8 codegen: Preserve parentheses from AST instead calculating
from operator precedence (#4055) (Boshen)
- 5e5b1b1 codegen: Correct accessibility emit for class
formal-parameters/methods/properties (#4042) (Egor Blinov)
- 7844734 codegen: Missing const keyword in TSTypeParamter (#4022)
(Dunqing)
- 6254a41 codegen: Missing TypeParamters in TSCallSignature (#4021)
(Dunqing)
- 3d29e9c isolated-declarations: Eliminate imports incorrectly when they
are used in `TSInferType` (#4043) (Dunqing)
- 02ea19a isolated-declarations: Should emit `export {}` when only
having `ImportDeclaration` (#4026) (Dunqing)
- 7c915f4 isolated-declarations: Binding elements with export should
report an error (#4025) (Dunqing)
- 05a047c isolated-declarations: Method following an abstract method
gets dropped (#4024) (Dunqing)
- c043bec isolated_declarations: Add mapped-type constraint to the scope
(#4037) (Egor Blinov)
- b007553 isolated_declarations: Fix readonly specifier on class
constructor params (#4030) (Egor Blinov)
- da62839 isolated_declarations: Inferring literal types for readonly
class fileds (#4027) (Egor Blinov)

### Refactor

- b51f75b ast_codegen: No longer outputs discard variable for empty
visitors. (#4008) (rzvxa)
- edb557c minifier: Add a folder struct for constant folding (#4057)
(Boshen)
- 243c9f3 parser: Use function instead of trait to parse list with rest
element (#4028) (Boshen)
- 1dacb1f parser: Use function instead of trait to parse delimited lists
(#4014) (Boshen)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant