feat(ast_codegen): introduce the #[span] hint.#4012
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 2, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Jul 1, 2024
This was referenced Jul 1, 2024
Contributor
Author
CodSpeed Performance ReportMerging #4012 will not alter performanceComparing Summary
|
Member
|
We can merge the whole stack, with uncertainties in a separate issue. |
rzvxa
force-pushed
the
07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s
branch
from
147d1ad to
173d474
Compare
rzvxa
force-pushed
the
07-02-feat_ast_codegen_introduce_the_span_hint
branch
from
6965c8f to
8e61e48
Compare
rzvxa
force-pushed
the
07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s
branch
from
173d474 to
f9311a1
Compare
github-actions
bot
added
A-semantic
rzvxa
force-pushed
the
07-02-feat_ast_codegen_introduce_the_span_hint
branch
from
8e61e48 to
97d682d
Compare
rzvxa
force-pushed
the
07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s
branch
from
f9311a1 to
271482d
Compare
rzvxa
force-pushed
the
07-02-feat_ast_codegen_introduce_the_span_hint
branch
from
97d682d to
2c7a188
Compare
Contributor
Author
I've fixed the down stack formatting issue, About the uncertainties; Are you talking about the conversations I've opened here #3954, If that's the case I have to say I agree. |
rzvxa
force-pushed
the
07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s
branch
from
271482d to
f744cef
Compare
rzvxa
force-pushed
the
07-02-feat_ast_codegen_introduce_the_span_hint
branch
from
2c7a188 to
05d597f
Compare
Contributor
Merge activity
|
rzvxa
force-pushed
the
07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s
branch
from
f744cef to
1f0d889
Compare
rzvxa
force-pushed
the
07-02-feat_ast_codegen_introduce_the_span_hint
branch
from
05d597f to
3bd5215
Compare
Boshen
force-pushed
the
07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s
branch
from
1f0d889 to
71e9286
Compare
Boshen
force-pushed
the
07-02-feat_ast_codegen_introduce_the_span_hint
branch
from
3bd5215 to
1854a52
Compare
Boshen
changed the base branch from
07-02-improvement_ast_codegen_use_visit_as_attribute_to_create_aliased_astkind_s
to
main
graphite-app
bot
deleted the
07-02-feat_ast_codegen_introduce_the_span_hint
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jul 5, 2024
## [0.17.0] - 2024-07-05 - e32b4bc ast: [**BREAKING**] Store trivia comments in a sorted slice (#4045) (Luca Bruno) - 1df6ac0 ast: [**BREAKING**] Rename `visit_enum_memeber` to `visit_ts_enum_member`. (#4000) (rzvxa) - 4a0eaa0 ast: [**BREAKING**] Rename `visit_enum` to `visit_ts_enum_declaration`. (#3998) (rzvxa) - c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to `visit_arrow_function_expression`. (#3995) (rzvxa) ### Features - 1854a52 ast_codegen: Introduce the `#[span]` hint. (#4012) (rzvxa) - 7538af1 ast_codegen: Add visit generator (#3954) (rzvxa) - 7768d23 isolated-declarations: Support optional class methods (#4035) (Egor Blinov) - 0da9dfb minifier: Add constant folding to remove dead code (#4058) (Boshen) ### Bug Fixes - aaac2d8 codegen: Preserve parentheses from AST instead calculating from operator precedence (#4055) (Boshen) - 5e5b1b1 codegen: Correct accessibility emit for class formal-parameters/methods/properties (#4042) (Egor Blinov) - 7844734 codegen: Missing const keyword in TSTypeParamter (#4022) (Dunqing) - 6254a41 codegen: Missing TypeParamters in TSCallSignature (#4021) (Dunqing) - 3d29e9c isolated-declarations: Eliminate imports incorrectly when they are used in `TSInferType` (#4043) (Dunqing) - 02ea19a isolated-declarations: Should emit `export {}` when only having `ImportDeclaration` (#4026) (Dunqing) - 7c915f4 isolated-declarations: Binding elements with export should report an error (#4025) (Dunqing) - 05a047c isolated-declarations: Method following an abstract method gets dropped (#4024) (Dunqing) - c043bec isolated_declarations: Add mapped-type constraint to the scope (#4037) (Egor Blinov) - b007553 isolated_declarations: Fix readonly specifier on class constructor params (#4030) (Egor Blinov) - da62839 isolated_declarations: Inferring literal types for readonly class fileds (#4027) (Egor Blinov) ### Refactor - b51f75b ast_codegen: No longer outputs discard variable for empty visitors. (#4008) (rzvxa) - edb557c minifier: Add a folder struct for constant folding (#4057) (Boshen) - 243c9f3 parser: Use function instead of trait to parse list with rest element (#4028) (Boshen) - 1dacb1f parser: Use function instead of trait to parse delimited lists (#4014) (Boshen) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3904