Skip to content

Comments

fix(linter): find disabled directives using the message's Span.#4010

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-01-fix_linter_find_disabled_directives_using_the_message_span_
Jul 2, 2024
Merged

fix(linter): find disabled directives using the message's Span.#4010
graphite-app[bot] merged 1 commit intomainfrom
07-01-fix_linter_find_disabled_directives_using_the_message_span_

Conversation

@rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 1, 2024

fixes #4005

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Jul 1, 2024
Copy link
Contributor Author

rzvxa commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa changed the title fix(linter): find disabled directives using the message Span. fix(linter): find disabled directives using the message's Span. Jul 1, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #4010 will not alter performance

Comparing 07-01-fix_linter_find_disabled_directives_using_the_message_span_ (432d6d9) with main (1854a52)

Summary

✅ 28 untouched benchmarks

@rzvxa rzvxa marked this pull request as ready for review July 1, 2024 21:09
@rzvxa rzvxa requested a review from DonIsaac July 1, 2024 21:09
@DonIsaac DonIsaac added the C-bug Category - Bug label Jul 1, 2024
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need a test case.

@rzvxa rzvxa force-pushed the 07-01-fix_linter_find_disabled_directives_using_the_message_span_ branch from b2d4726 to 87ba0cb Compare July 2, 2024 09:36
@rzvxa rzvxa requested a review from Boshen July 2, 2024 09:43
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 2, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 2, 2024

Merge activity

  • Jul 2, 6:02 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 2, 6:42 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 2, 7:03 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 07-01-fix_linter_find_disabled_directives_using_the_message_span_ branch from 6cfbff2 to 432d6d9 Compare July 2, 2024 10:49
@graphite-app graphite-app bot merged commit 432d6d9 into main Jul 2, 2024
@graphite-app graphite-app bot deleted the 07-01-fix_linter_find_disabled_directives_using_the_message_span_ branch July 2, 2024 11:03
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Boshen added a commit that referenced this pull request Jul 2, 2024
## [0.6.0] - 2024-07-02

- c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to
`visit_arrow_function_expression`. (#3995) (rzvxa)

### Features

- dc6d45e ast,codegen: Add `TSParenthesizedType` and print type
parentheses correctly (#3979) (Boshen)
- b257d53 linter: Support report
`@typescript-eslint/consistent-type-imports` (#3895) (mysteryven)
- 2114475 linter: Implement @typescript-eslint/no-dynamic-delete (#3971)
(kaykdm)
- 10a3c9a linter/eslint-plugin-react: Implement no-set-state (#3975)
(Jelle van der Waa)

### Bug Fixes

- 432d6d9 linter: Find disabled directives using the message's `Span`.
(#4010) (rzvxa)
- dbbb6fc linter: Global variable check should always check builtin
variables (#3973) (Boshen)

### Performance

- 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac)

### Refactor

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: no-empty-file does not respect disable directive comments

3 participants