fix(semantic): resolve reference incorrectly when a parameter references a parameter that hasn't been defined yet#4004
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 2, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #4004 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
07-02-fix_semantic_resolve_reference_incorrectly_when_a_parameter_references_a_parameter_that_hasn_t_been_defined_yet
branch
2 times, most recently
from
717d7c0 to
c2a5382
Compare
Boshen
approved these changes
Jul 2, 2024
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
This is indeed more logical than what we had before.
Contributor
Merge activity
|
…ces a parameter that hasn't been defined yet (#4004) close: #3682 The TypeScript code that handles this is [here](https://github.com/Dunqing/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/utilities.ts#L11515-L11577). It looks complicated.
Boshen
force-pushed
the
07-02-fix_semantic_resolve_reference_incorrectly_when_a_parameter_references_a_parameter_that_hasn_t_been_defined_yet
branch
from
c2a5382 to
d995f94
Compare
graphite-app
bot
deleted the
07-02-fix_semantic_resolve_reference_incorrectly_when_a_parameter_references_a_parameter_that_hasn_t_been_defined_yet
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jul 2, 2024
## [0.16.3] - 2024-07-02 ### Features - b257d53 linter: Support report `@typescript-eslint/consistent-type-imports` (#3895) (mysteryven) ### Bug Fixes - 23038ad codegen: Print `TSFunctionType` inside `TSTypeAssertion` (#3999) (Boshen) - d995f94 semantic: Resolve reference incorrectly when a parameter references a parameter that hasn't been defined yet (#4004) (Dunqing) - bdee156 transformer/typescript: `declare class` incorrectly preserved as runtime class (#3997) (Dunqing) - a50ce3d transformer/typescript: Missing initializer for class constructor arguments with `private` and `protected` modifier (#3996) (Dunqing) ### Refactor - 0fe22a8 ast: Reorder fields to reflect their visit order. (#3994) (rzvxa) - d0eac46 parser: Use function instead of trait to parse normal lists (#4003) (Boshen) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #3682
The TypeScript code that handles this is here. It looks complicated.