Skip to content

Comments

feat(ast,codegen): add TSParenthesizedType and print type parentheses correctly#3979

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-30-feat_ast_codegen_add_tsparenthesizedtype_and_print_parentheses_correctly
Jun 30, 2024
Merged

feat(ast,codegen): add TSParenthesizedType and print type parentheses correctly#3979
graphite-app[bot] merged 1 commit intomainfrom
06-30-feat_ast_codegen_add_tsparenthesizedtype_and_print_parentheses_correctly

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jun 30, 2024

closes #3916

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST A-codegen Area - Code Generation A-prettier A-isolated-declarations Isolated Declarations labels Jun 30, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 30, 2024

CodSpeed Performance Report

Merging #3979 will not alter performance

Comparing 06-30-feat_ast_codegen_add_tsparenthesizedtype_and_print_parentheses_correctly (dc6d45e) with main (5845057)

Summary

✅ 28 untouched benchmarks

@Boshen Boshen force-pushed the 06-30-feat_ast_codegen_add_tsparenthesizedtype_and_print_parentheses_correctly branch from c34b882 to 3e65909 Compare June 30, 2024 07:52
@github-actions github-actions bot added the A-linter Area - Linter label Jun 30, 2024
@Boshen Boshen changed the title feat(ast,codegen): add TSParenthesizedType and type print parentheses correctly feat(ast,codegen): add TSParenthesizedType and print type parentheses correctly Jun 30, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 30, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 30, 2024

Merge activity

  • Jun 30, 3:55 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 30, 3:57 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 30, 4:01 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 06-30-feat_ast_codegen_add_tsparenthesizedtype_and_print_parentheses_correctly branch from 3e65909 to dc6d45e Compare June 30, 2024 07:57
@graphite-app graphite-app bot merged commit dc6d45e into main Jun 30, 2024
@graphite-app graphite-app bot deleted the 06-30-feat_ast_codegen_add_tsparenthesizedtype_and_print_parentheses_correctly branch June 30, 2024 08:01
@github-actions github-actions bot mentioned this pull request Jun 30, 2024
Boshen added a commit that referenced this pull request Jun 30, 2024
## [0.16.2] - 2024-06-30

### Features

- dc6d45e ast,codegen: Add `TSParenthesizedType` and print type
parentheses correctly (#3979) (Boshen)
- 63f36da parser: Parse modifiers with `parse_modifiers` (take 2)
(#3977) (DonIsaac)

### Bug Fixes

- dac617d codegen: Print some missing typescript attributes (#3980)
(Boshen)
- bd1141d isolated-declarations: If declarations is referenced in
`declare global` then keep it (#3982) (Dunqing)

### Performance

- b234ddd semantic: Only check for jsdoc if jsdoc building is enabled
(Boshen)
- 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac)
- 0c81fbe syntax: Use `NonZeroU32` for `SymbolId` and `ReferenceId`
(#3970) (Boshen)

### Refactor

- 5845057 transformer: Pass in symbols and scopes (#3978) (Boshen)

Co-authored-by: Boshen <[email protected]>
This was referenced Jul 1, 2024
Boshen added a commit that referenced this pull request Jul 2, 2024
## [0.6.0] - 2024-07-02

- c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to
`visit_arrow_function_expression`. (#3995) (rzvxa)

### Features

- dc6d45e ast,codegen: Add `TSParenthesizedType` and print type
parentheses correctly (#3979) (Boshen)
- b257d53 linter: Support report
`@typescript-eslint/consistent-type-imports` (#3895) (mysteryven)
- 2114475 linter: Implement @typescript-eslint/no-dynamic-delete (#3971)
(kaykdm)
- 10a3c9a linter/eslint-plugin-react: Implement no-set-state (#3975)
(Jelle van der Waa)

### Bug Fixes

- 432d6d9 linter: Find disabled directives using the message's `Span`.
(#4010) (rzvxa)
- dbbb6fc linter: Global variable check should always check builtin
variables (#3973) (Boshen)

### Performance

- 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac)

### Refactor

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-linter Area - Linter A-parser Area - Parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isolatedDeclaration emits excess parentheses in union types

1 participant