Skip to content

Comments

feat(linter/eslint-plugin-react): Implement no-set-state#3975

Merged
Boshen merged 1 commit intooxc-project:mainfrom
jelly:react/no-set-state
Jun 30, 2024
Merged

feat(linter/eslint-plugin-react): Implement no-set-state#3975
Boshen merged 1 commit intooxc-project:mainfrom
jelly:react/no-set-state

Conversation

@jelly
Copy link
Contributor

@jelly jelly commented Jun 29, 2024

Rule Detail:

link

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Jun 29, 2024
@jelly jelly force-pushed the react/no-set-state branch from bab3082 to 5e7b3a2 Compare June 29, 2024 15:49
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 29, 2024

CodSpeed Performance Report

Merging #3975 will not alter performance

Comparing jelly:react/no-set-state (5e7b3a2) with main (dbbb6fc)

Summary

✅ 28 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 30, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 30, 2024

Merge activity

  • Jun 30, 7:10 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 30, 7:10 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 30, 7:10 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 30, 2024
@Boshen Boshen merged commit 10a3c9a into oxc-project:main Jun 30, 2024
This was referenced Jul 1, 2024
Boshen added a commit that referenced this pull request Jul 2, 2024
## [0.6.0] - 2024-07-02

- c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to
`visit_arrow_function_expression`. (#3995) (rzvxa)

### Features

- dc6d45e ast,codegen: Add `TSParenthesizedType` and print type
parentheses correctly (#3979) (Boshen)
- b257d53 linter: Support report
`@typescript-eslint/consistent-type-imports` (#3895) (mysteryven)
- 2114475 linter: Implement @typescript-eslint/no-dynamic-delete (#3971)
(kaykdm)
- 10a3c9a linter/eslint-plugin-react: Implement no-set-state (#3975)
(Jelle van der Waa)

### Bug Fixes

- 432d6d9 linter: Find disabled directives using the message's `Span`.
(#4010) (rzvxa)
- dbbb6fc linter: Global variable check should always check builtin
variables (#3973) (Boshen)

### Performance

- 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac)

### Refactor

Co-authored-by: Boshen <[email protected]>
@jelly jelly deleted the react/no-set-state branch August 22, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants