Skip to content

Comments

Revert "perf(semantic): use Atom<'a> for References"#3974

Merged
graphite-app[bot] merged 1 commit intomainfrom
revert-3972-don/semantic/perf/compact-str
Jun 29, 2024
Merged

Revert "perf(semantic): use Atom<'a> for References"#3974
graphite-app[bot] merged 1 commit intomainfrom
revert-3972-don/semantic/perf/compact-str

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jun 29, 2024

Reverts #3972

@DonIsaac As it turns out we can't have lifetimes on these structures because semantic data is exposed to downstream users to use freely, detached from the ast and allocator.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler labels Jun 29, 2024
@DonIsaac
Copy link
Contributor

DonIsaac commented Jun 29, 2024

Does adding lifetimes break downstream consumers?

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3974 will degrade performances by 6.92%

Comparing revert-3972-don/semantic/perf/compact-str (54c653e) with main (dbbb6fc)

Summary

❌ 6 regressions
✅ 22 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main revert-3972-don/semantic/perf/compact-str Change
❌ semantic[antd.js] 189.1 ms 198.3 ms -4.66%
❌ semantic[checker.ts] 120.1 ms 129.1 ms -6.92%
❌ semantic[pdf.mjs] 29.6 ms 31.4 ms -5.57%
❌ transformer[antd.js] 323.1 ms 335.6 ms -3.74%
❌ transformer[checker.ts] 190.4 ms 202.1 ms -5.79%
❌ transformer[pdf.mjs] 51.1 ms 53 ms -3.53%

@Boshen
Copy link
Member Author

Boshen commented Jun 29, 2024

Does adding lifetimes break downstream consumers?

Yes, I forgot to mention Rolldown. https://github.com/rolldown/rolldown/blob/87ec563e8bc1a2241d80a40452c8dc7c6c59ad06/crates/rolldown_common/src/module/normal_module.rs#L42

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2024 •
edited
Loading

Merge activity

  • Jun 29, 11:54 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 11:54 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 29, 11:59 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen
Revert "perf(semantic): use Atom<'a> for References" (#3974)
54c653e 
Reverts #3972

@DonIsaac As it turns out we can't have lifetimes on these structures because semantic data is exposed to downstream users to use freely, detached from the ast and allocator.
@Boshen Boshen force-pushed the revert-3972-don/semantic/perf/compact-str branch from b332684 to 54c653e Compare June 29, 2024 15:55
@graphite-app graphite-app bot merged commit 54c653e into main Jun 29, 2024
@graphite-app graphite-app bot deleted the revert-3972-don/semantic/perf/compact-str branch June 29, 2024 15:59
@overlookmotel overlookmotel mentioned this pull request Jul 1, 2024
Closed
@overlookmotel overlookmotel mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter A-minifier Area - Minifier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen @DonIsaac