Skip to content

Comments

refactor(linter): improve diagnostic labeling#3960

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/linter/refactor/label-improvements
Jun 29, 2024
Merged

refactor(linter): improve diagnostic labeling#3960
graphite-app[bot] merged 1 commit intomainfrom
don/linter/refactor/label-improvements

Conversation

@DonIsaac
Copy link
Contributor

No description provided.

@DonIsaac DonIsaac added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 28, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler labels Jun 28, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 28, 2024

CodSpeed Performance Report

Merging #3960 will not alter performance

Comparing don/linter/refactor/label-improvements (2705df9) with main (f64ad4b)

Summary

✅ 28 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2024

Merge activity

  • Jun 29, 1:13 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 1:13 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 29, 1:23 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the don/linter/refactor/label-improvements branch from b83974d to 2705df9 Compare June 29, 2024 05:19
@graphite-app graphite-app bot merged commit 2705df9 into main Jun 29, 2024
@graphite-app graphite-app bot deleted the don/linter/refactor/label-improvements branch June 29, 2024 05:23
This was referenced Jun 29, 2024
Boshen added a commit that referenced this pull request Jun 29, 2024
## [0.16.1] - 2024-06-29

### Features

- 7b38bde parser: Parse modifiers with `parse_modifiers` (#3948)
(DonIsaac)
- f64ad4b semantic: Make jsdoc building optional (turned off by default)
(#3955) (Boshen)

### Bug Fixes

- 51e54f9 codegen: Should print `TSModuleDeclarationKind` instead of
just `module` (#3957) (Dunqing)
- 31e4c3b isolated-declarations: `declare global {}` should be kept even
if it is not exported (#3956) (Dunqing)

### Refactor

- 2705df9 linter: Improve diagnostic labeling (#3960) (DonIsaac)
- 15ec254 semantic: Remove the unused `Semantic::build2` function
(Boshen)

Co-authored-by: Boshen <[email protected]>
Boshen added a commit that referenced this pull request Jun 29, 2024
## [0.5.1] - 2024-06-29

### Features

- f64ad4b semantic: Make jsdoc building optional (turned off by default)
(#3955) (Boshen)

### Bug Fixes

- c26975a linter: Only show the filename for max-lines (#3966) (Boshen)
- 94329e4 linter: Handle useful but empty constructors in
no-useless-constructor (#3951) (DonIsaac)
- 6498a08 linter: No-useless-spread fixer with multiple spread elements
(#3950) (DonIsaac)
- 750cb43 oxlint: Gate custom allocators by feature flag (#3945) (Luca
Bruno)

### Refactor

- 1cca2a8 eslint: Convert with_labels to with_label where applicable
(#3946) (Jelle van der Waa)
- 2705df9 linter: Improve diagnostic labeling (#3960) (DonIsaac)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants