Skip to content

Comments

fix(codegen): should print TSModuleDeclarationKind instead of just module#3957

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-29-fix_codegen_should_print_tsmoduledeclarationkind_instead_of_just_module
Jun 29, 2024
Merged

fix(codegen): should print TSModuleDeclarationKind instead of just module#3957
graphite-app[bot] merged 1 commit intomainfrom
06-29-fix_codegen_should_print_tsmoduledeclarationkind_instead_of_just_module

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jun 28, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Jun 28, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 28, 2024

CodSpeed Performance Report

Merging #3957 will not alter performance

Comparing 06-29-fix_codegen_should_print_tsmoduledeclarationkind_instead_of_just_module (51e54f9) with main (2705df9)

Summary

✅ 28 untouched benchmarks

@Dunqing Dunqing force-pushed the 06-29-fix_codegen_should_print_tsmoduledeclarationkind_instead_of_just_module branch from d4b6e69 to 3ccf963 Compare June 29, 2024 03:20
@Boshen Boshen force-pushed the 06-28-fix_isolated-declarations_declare_global_should_be_kept_even_if_it_is_not_exported branch from 232b2b6 to 31e4c3b Compare June 29, 2024 05:07
@Boshen Boshen changed the base branch from 06-28-fix_isolated-declarations_declare_global_should_be_kept_even_if_it_is_not_exported to main June 29, 2024 05:11
@Boshen Boshen force-pushed the 06-29-fix_codegen_should_print_tsmoduledeclarationkind_instead_of_just_module branch from 3ccf963 to a87b455 Compare June 29, 2024 05:11
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2024

Merge activity

  • Jun 29, 1:14 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 1:18 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 29, 1:28 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 06-29-fix_codegen_should_print_tsmoduledeclarationkind_instead_of_just_module branch from a87b455 to 51e54f9 Compare June 29, 2024 05:24
@graphite-app graphite-app bot merged commit 51e54f9 into main Jun 29, 2024
@graphite-app graphite-app bot deleted the 06-29-fix_codegen_should_print_tsmoduledeclarationkind_instead_of_just_module branch June 29, 2024 05:28
@github-actions github-actions bot mentioned this pull request Jun 29, 2024
Boshen added a commit that referenced this pull request Jun 29, 2024
## [0.16.1] - 2024-06-29

### Features

- 7b38bde parser: Parse modifiers with `parse_modifiers` (#3948)
(DonIsaac)
- f64ad4b semantic: Make jsdoc building optional (turned off by default)
(#3955) (Boshen)

### Bug Fixes

- 51e54f9 codegen: Should print `TSModuleDeclarationKind` instead of
just `module` (#3957) (Dunqing)
- 31e4c3b isolated-declarations: `declare global {}` should be kept even
if it is not exported (#3956) (Dunqing)

### Refactor

- 2705df9 linter: Improve diagnostic labeling (#3960) (DonIsaac)
- 15ec254 semantic: Remove the unused `Semantic::build2` function
(Boshen)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants