feat(ast_codegen): add visit generator#3954
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 2, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
Boshen
force-pushed
the
06-26-improvement_ast_codegen_better_output_formatting
branch
from
0bd52d0 to
71c07c5
Compare
Boshen
changed the base branch from
06-26-improvement_ast_codegen_better_output_formatting
to
main
Boshen
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
fb2dfc5 to
7473cac
Compare
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
2 times, most recently
from
1eed4e1 to
4489d53
Compare
github-actions
bot
added
A-semantic
rzvxa
changed the title
visit.rs
CodSpeed Performance ReportMerging #3954 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
rzvxa
commented
Jun 30, 2024
rzvxa
commented
Jun 30, 2024
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
3 times, most recently
from
d1bc354 to
c3e7710
Compare
rzvxa
changed the base branch from
main
to
07-01-refactor_ast_reorder_fields_to_reflect_their_visit_order
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
c3e7710 to
35ac9d7
Compare
rzvxa
changed the base branch from
07-01-refactor_ast_reorder_fields_to_reflect_their_visit_order
to
07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
35ac9d7 to
dfd94b9
Compare
rzvxa
changed the base branch from
07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_
to
07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
dfd94b9 to
38939d3
Compare
rzvxa
changed the base branch from
07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_
to
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
826b3a4 to
684107f
Compare
This was referenced Jul 1, 2024
rzvxa
force-pushed
the
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
branch
from
dcbcb58 to
03d7237
Compare
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
684107f to
e48dcda
Compare
rzvxa
force-pushed
the
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
branch
from
03d7237 to
6a98d54
Compare
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
e48dcda to
6945378
Compare
rzvxa
force-pushed
the
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
branch
from
6a98d54 to
11196b8
Compare
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
6945378 to
e621e99
Compare
Boshen
force-pushed
the
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
branch
from
11196b8 to
3d6f9bb
Compare
rzvxa
force-pushed
the
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
branch
from
3d6f9bb to
354a28e
Compare
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
e621e99 to
c9cbb2f
Compare
rzvxa
force-pushed
the
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
branch
from
354a28e to
1df6ac0
Compare
rzvxa
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
c9cbb2f to
2b20de5
Compare
Contributor
Merge activity
|
Boshen
changed the base branch from
07-01-refactor_ast_rename_visit_enum_memeber_to_visit_ts_enum_member_
to
main
~~The generated code is only here for the sake of my own comparison (instead of manually keeping a backup of the old generated file). I would clean this up as soon as it is ready, submit some parts of it as the down stack, and stack the actual generated code on top of this. So please don't let the huge diff distract you, It won't have many conflicts since almost all of these are the generated visit code, which is completely contained to its own module(other than some minor renaming refactors).~~ The order of function definitions is a bit different, I've used a depth-first search, We can switch to a breadth-first one to align functions more closely to the original.
Boshen
force-pushed
the
06-28-feat_ast_codegen_generate_visit.rs_
branch
from
2b20de5 to
7538af1
Compare
Merged
Boshen
added a commit
that referenced
this pull request
Jul 5, 2024
## [0.17.0] - 2024-07-05 - e32b4bc ast: [**BREAKING**] Store trivia comments in a sorted slice (#4045) (Luca Bruno) - 1df6ac0 ast: [**BREAKING**] Rename `visit_enum_memeber` to `visit_ts_enum_member`. (#4000) (rzvxa) - 4a0eaa0 ast: [**BREAKING**] Rename `visit_enum` to `visit_ts_enum_declaration`. (#3998) (rzvxa) - c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to `visit_arrow_function_expression`. (#3995) (rzvxa) ### Features - 1854a52 ast_codegen: Introduce the `#[span]` hint. (#4012) (rzvxa) - 7538af1 ast_codegen: Add visit generator (#3954) (rzvxa) - 7768d23 isolated-declarations: Support optional class methods (#4035) (Egor Blinov) - 0da9dfb minifier: Add constant folding to remove dead code (#4058) (Boshen) ### Bug Fixes - aaac2d8 codegen: Preserve parentheses from AST instead calculating from operator precedence (#4055) (Boshen) - 5e5b1b1 codegen: Correct accessibility emit for class formal-parameters/methods/properties (#4042) (Egor Blinov) - 7844734 codegen: Missing const keyword in TSTypeParamter (#4022) (Dunqing) - 6254a41 codegen: Missing TypeParamters in TSCallSignature (#4021) (Dunqing) - 3d29e9c isolated-declarations: Eliminate imports incorrectly when they are used in `TSInferType` (#4043) (Dunqing) - 02ea19a isolated-declarations: Should emit `export {}` when only having `ImportDeclaration` (#4026) (Dunqing) - 7c915f4 isolated-declarations: Binding elements with export should report an error (#4025) (Dunqing) - 05a047c isolated-declarations: Method following an abstract method gets dropped (#4024) (Dunqing) - c043bec isolated_declarations: Add mapped-type constraint to the scope (#4037) (Egor Blinov) - b007553 isolated_declarations: Fix readonly specifier on class constructor params (#4030) (Egor Blinov) - da62839 isolated_declarations: Inferring literal types for readonly class fileds (#4027) (Egor Blinov) ### Refactor - b51f75b ast_codegen: No longer outputs discard variable for empty visitors. (#4008) (rzvxa) - edb557c minifier: Add a folder struct for constant folding (#4057) (Boshen) - 243c9f3 parser: Use function instead of trait to parse list with rest element (#4028) (Boshen) - 1dacb1f parser: Use function instead of trait to parse delimited lists (#4014) (Boshen) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated code is only here for the sake of my own comparison (instead of manually keeping a backup of the old generated file). I would clean this up as soon as it is ready, submit some parts of it as the down stack, and stack the actual generated code on top of this. So please don't let the huge diff distract you, It won't have many conflicts since almost all of these are the generated visit code, which is completely contained to its own module(other than some minor renaming refactors).The order of function definitions is a bit different, I've used a depth-first search, We can switch to a breadth-first one to align functions more closely to the original.