Skip to content

Comments

feat(parser): parse modifiers with parse_modifiers#3948

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/parser/feat/modifiers
Jun 29, 2024
Merged

feat(parser): parse modifiers with parse_modifiers#3948
graphite-app[bot] merged 1 commit intomainfrom
don/parser/feat/modifiers

Conversation

@DonIsaac
Copy link
Contributor

Closes #3929

@DonIsaac DonIsaac added C-enhancement Category - New feature or request A-parser Area - Parser labels Jun 27, 2024
@DonIsaac DonIsaac self-assigned this Jun 27, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #3948 will not alter performance

Comparing don/parser/feat/modifiers (7b38bde) with main (51e54f9)

Summary

✅ 28 untouched benchmarks

@DonIsaac DonIsaac marked this pull request as ready for review June 27, 2024 22:01
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jun 27, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2024

Merge activity

  • Jun 29, 1:27 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 1:27 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 29, 1:34 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the don/parser/feat/modifiers branch from bf8300e to 59b9b90 Compare June 29, 2024 05:27
@Boshen Boshen force-pushed the don/parser/feat/modifiers branch from 59b9b90 to 7b38bde Compare June 29, 2024 05:30
@graphite-app graphite-app bot merged commit 7b38bde into main Jun 29, 2024
@graphite-app graphite-app bot deleted the don/parser/feat/modifiers branch June 29, 2024 05:34
Boshen added a commit that referenced this pull request Jun 29, 2024
@github-actions github-actions bot mentioned this pull request Jun 29, 2024
Boshen added a commit that referenced this pull request Jun 29, 2024
## [0.16.1] - 2024-06-29

### Features

- 7b38bde parser: Parse modifiers with `parse_modifiers` (#3948)
(DonIsaac)
- f64ad4b semantic: Make jsdoc building optional (turned off by default)
(#3955) (Boshen)

### Bug Fixes

- 51e54f9 codegen: Should print `TSModuleDeclarationKind` instead of
just `module` (#3957) (Dunqing)
- 31e4c3b isolated-declarations: `declare global {}` should be kept even
if it is not exported (#3956) (Dunqing)

### Refactor

- 2705df9 linter: Improve diagnostic labeling (#3960) (DonIsaac)
- 15ec254 semantic: Remove the unused `Semantic::build2` function
(Boshen)

Co-authored-by: Boshen <[email protected]>
@DonIsaac DonIsaac restored the don/parser/feat/modifiers branch June 29, 2024 23:04
Boshen pushed a commit that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parser: finish parsing of Modifiers

2 participants