fix(oxlint): gate custom allocators by feature flag#3945
fix(oxlint): gate custom allocators by feature flag#3945Boshen merged 1 commit intooxc-project:mainfrom
Conversation
This tweaks the conditional compilation of custom allocators by wiring the dedicated Cargo feature flag `allocator` to the source code. It ensures that allocator gating is directly checking the relevant feature instead of trying to infer it from the build profile.
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3945 will not alter performanceComparing Summary
|
|
My intention was to not enable allocators in dev mode, which hurts compilation speed for first timers. |
|
@lucab Thank you for going through our code. I assume you are a very good system engineer, I'm happy to help you and get you on-boarded with this project, as we appreciate a lot of helping hands. Please DM me either on twitter or discord for some quick chats. For more hardcore problems, you may checkout our backlog https://github.com/oxc-project/backlog/issues, there are problems like custom arena allocator that may interest you. |
## [0.5.1] - 2024-06-29 ### Features - f64ad4b semantic: Make jsdoc building optional (turned off by default) (#3955) (Boshen) ### Bug Fixes - c26975a linter: Only show the filename for max-lines (#3966) (Boshen) - 94329e4 linter: Handle useful but empty constructors in no-useless-constructor (#3951) (DonIsaac) - 6498a08 linter: No-useless-spread fixer with multiple spread elements (#3950) (DonIsaac) - 750cb43 oxlint: Gate custom allocators by feature flag (#3945) (Luca Bruno) ### Refactor - 1cca2a8 eslint: Convert with_labels to with_label where applicable (#3946) (Jelle van der Waa) - 2705df9 linter: Improve diagnostic labeling (#3960) (DonIsaac) Co-authored-by: Boshen <[email protected]>
|
Thanks for the pointers. I had a look at your backlog tracker and I'm also around on the discord server. Unfortunately these days I don't have large uninterrupted chunks of time to dedicate to larger tasks, and I'm also often away from my usual coding environment. I'm enjoying exploring both |
|
@lucab That's ok, feel free to raise issues or DM them if you find anything that is interesting or worth exploring, I can create some good first issues if you don't have the time to code 😁 |
2 participants
This tweaks the conditional compilation of custom allocators by wiring the dedicated Cargo feature flag
allocatorto the source code. It ensures that allocator gating is directly checking the relevant feature instead of trying to infer it from the build profile.