Skip to content

Comments

refactor(linter): pass Rc by value#3587

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-08-refactor_linter_pass_rc_by_value
Jun 8, 2024
Merged

refactor(linter): pass Rc by value#3587
graphite-app[bot] merged 1 commit intomainfrom
06-08-refactor_linter_pass_rc_by_value

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jun 8, 2024

Same as #3586.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Jun 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Jun 8, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 8, 2024

CodSpeed Performance Report

Merging #3587 will not alter performance

Comparing 06-08-refactor_linter_pass_rc_by_value (fa11644) with main (6bdd74c)

Summary

✅ 22 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review June 8, 2024 09:44
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 8, 2024

Merge activity

@Boshen Boshen force-pushed the 06-08-refactor_semantic_pass_rc_by_value branch from 110bb12 to 7d61832 Compare June 8, 2024 11:19
@Boshen Boshen force-pushed the 06-08-refactor_linter_pass_rc_by_value branch from 6dc34f6 to fa11644 Compare June 8, 2024 11:19
@Boshen Boshen changed the base branch from 06-08-refactor_semantic_pass_rc_by_value to main June 8, 2024 11:23
@graphite-app graphite-app bot merged commit fa11644 into main Jun 8, 2024
@graphite-app graphite-app bot deleted the 06-08-refactor_linter_pass_rc_by_value branch June 8, 2024 11:24
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Boshen added a commit that referenced this pull request Jun 14, 2024
## [0.4.4] - 2024-06-14

### Features

- 8f5655d linter: Add eslint/no-useless-constructor (#3594) (Don Isaac)
- 29c78db linter: Implement
@typescript-eslint/explicit-function-return-type (#3455) (kaykdm)
- 21d3425 linter: Typescript-eslint no-useless-empty-export (#3605)
(keita hino)
- 85c3b83 linter: Eslint-plugin-jest/max-nested-describes (#3585)
(cinchen)
- f6d9ca6 linter: Add `eslint/sort-imports` rule (#3568) (Wang Wenzhe)
- 046ff3f linter/eslint: Add `no_unreachable` rule. (#3238) (rzvxa)
- e32ce00 linter/jsdoc: Implement require-param-name rule (#3636) (Yuji
Sugiura)
- 110661c linter/jsdoc: Implement require-param-description (#3621)
(Yuji Sugiura)
- d6370f1 linter/jsdoc: Implement require-param-type rule (#3601) (Yuji
Sugiura)
- d9c5b33 semantic/cfg: Add `Condition` instruction. (#3567) (Ali
Rezvani)
- f2dfd66 semantic/cfg: Add iteration instructions. (#3566) (rzvxa)

### Bug Fixes

- f0b689d linter: Panic in jsdoc/require-param (#3590) (Don Isaac)
- e148a32 semantic/cfg: Correct unreachability propagation in
try-finally. (#3667) (Ali Rezvani)

### Refactor

- 84304b4 linter: Add a `ctx.module_record()` method (#3637) (Boshen)
- f98f777 linter: Add rule fixer (#3589) (Don Isaac)
- fa11644 linter: Pass `Rc` by value (#3587) (overlookmotel)
- f702fb9 semantic/cfg: Cleanup control flow and it's builder. (#3650)
(rzvxa)
- 5793ff1 transformer: Replace `&’a Trivias` with `Rc<Trivias>` (#3580)
(Dunqing)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant