Skip to content

Comments

feat(linter): eslint-plugin-jest/max-nested-describes#3585

Merged
mysteryven merged 5 commits intooxc-project:mainfrom
eryue0220:feat/jest-max-nested-describe-rule
Jun 11, 2024
Merged

feat(linter): eslint-plugin-jest/max-nested-describes#3585
mysteryven merged 5 commits intooxc-project:mainfrom
eryue0220:feat/jest-max-nested-describe-rule

Conversation

@eryue0220
Copy link
Contributor

@eryue0220 eryue0220 commented Jun 8, 2024

part of #492

Rule Detail: link

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Jun 8, 2024
@eryue0220 eryue0220 changed the title feat: add new rule feat(linter): eslint-plugin-jest/max-nested-describes Jun 8, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 8, 2024

CodSpeed Performance Report

Merging #3585 will not alter performance

Comparing eryue0220:feat/jest-max-nested-describe-rule (1b24e08) with main (e6ad3fb)

Summary

✅ 22 untouched benchmarks

@mysteryven
Copy link
Contributor

I merge this because all comment be resolved and look good to me.

@mysteryven mysteryven merged commit 85c3b83 into oxc-project:main Jun 11, 2024
@eryue0220 eryue0220 deleted the feat/jest-max-nested-describe-rule branch June 12, 2024 00:32
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Boshen added a commit that referenced this pull request Jun 14, 2024
## [0.4.4] - 2024-06-14

### Features

- 8f5655d linter: Add eslint/no-useless-constructor (#3594) (Don Isaac)
- 29c78db linter: Implement
@typescript-eslint/explicit-function-return-type (#3455) (kaykdm)
- 21d3425 linter: Typescript-eslint no-useless-empty-export (#3605)
(keita hino)
- 85c3b83 linter: Eslint-plugin-jest/max-nested-describes (#3585)
(cinchen)
- f6d9ca6 linter: Add `eslint/sort-imports` rule (#3568) (Wang Wenzhe)
- 046ff3f linter/eslint: Add `no_unreachable` rule. (#3238) (rzvxa)
- e32ce00 linter/jsdoc: Implement require-param-name rule (#3636) (Yuji
Sugiura)
- 110661c linter/jsdoc: Implement require-param-description (#3621)
(Yuji Sugiura)
- d6370f1 linter/jsdoc: Implement require-param-type rule (#3601) (Yuji
Sugiura)
- d9c5b33 semantic/cfg: Add `Condition` instruction. (#3567) (Ali
Rezvani)
- f2dfd66 semantic/cfg: Add iteration instructions. (#3566) (rzvxa)

### Bug Fixes

- f0b689d linter: Panic in jsdoc/require-param (#3590) (Don Isaac)
- e148a32 semantic/cfg: Correct unreachability propagation in
try-finally. (#3667) (Ali Rezvani)

### Refactor

- 84304b4 linter: Add a `ctx.module_record()` method (#3637) (Boshen)
- f98f777 linter: Add rule fixer (#3589) (Don Isaac)
- fa11644 linter: Pass `Rc` by value (#3587) (overlookmotel)
- f702fb9 semantic/cfg: Cleanup control flow and it's builder. (#3650)
(rzvxa)
- 5793ff1 transformer: Replace `&’a Trivias` with `Rc<Trivias>` (#3580)
(Dunqing)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants