Skip to content

Comments

improve(transformer): create Atom for react import source lazily#3578

Merged
Dunqing merged 2 commits intomainfrom
06-06-improve_transformer_create_atom_for_react_import_source_lazily
Jun 7, 2024
Merged

improve(transformer): create Atom for react import source lazily#3578
Dunqing merged 2 commits intomainfrom
06-06-improve_transformer_create_atom_for_react_import_source_lazily

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jun 6, 2024

In JSX transform:

  • Don't generate an Atom for react importer unless it's needed.
  • Re-use the same string slice as jsx_runtime_importer.
  • Reduce size of Bindings.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Jun 6, 2024

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jun 6, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #3578 will not alter performance

Comparing 06-06-improve_transformer_create_atom_for_react_import_source_lazily (0e30f8b) with 06-06-perf_transformer_faster_checks_if_jsx_plugin_enabled (1054ff7)

Summary

✅ 22 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review June 6, 2024 20:56
@Dunqing Dunqing force-pushed the 06-06-perf_transformer_faster_checks_if_jsx_plugin_enabled branch from 1054ff7 to 37cdc13 Compare June 7, 2024 03:16
@Dunqing Dunqing changed the base branch from 06-06-perf_transformer_faster_checks_if_jsx_plugin_enabled to main June 7, 2024 03:20
@Boshen Boshen requested a review from Dunqing June 7, 2024 04:08
@Dunqing Dunqing merged commit 3d0e790 into main Jun 7, 2024
@Dunqing Dunqing deleted the 06-06-improve_transformer_create_atom_for_react_import_source_lazily branch June 7, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants