Skip to content

feat(transformer/typescript): remove typescript ast nodes#3559

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-06-feat_transformer_typescript_remove_typescript_ast_nodes
Jun 7, 2024
Merged

feat(transformer/typescript): remove typescript ast nodes#3559
graphite-app[bot] merged 1 commit intomainfrom
06-06-feat_transformer_typescript_remove_typescript_ast_nodes

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jun 6, 2024

According to Babel tests feedback, remove some known ts AST nodes.
There are still many TS AST nodes that need to be deleted

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Jun 6, 2024

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Jun 6, 2024
@Dunqing Dunqing marked this pull request as ready for review June 6, 2024 08:18
@Dunqing Dunqing force-pushed the 06-06-feat_transformer_typescript_remove_typescript_ast_nodes branch from 554cf3a to 900bc42 Compare June 6, 2024 08:27
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #3559 will not alter performance

Comparing 06-06-feat_transformer_typescript_remove_typescript_ast_nodes (e8a20f8) with main (37cdc13)

Summary

✅ 22 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 6, 2024

Merge activity

  • Jun 6, 8:18 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 6, 8:28 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Check Unused Dependencies').
  • Jun 7, 1:03 AM EDT: Dunqing added this pull request to the Graphite merge queue.
  • Jun 7, 1:08 AM EDT: Dunqing merged this pull request with the Graphite merge queue.

Boshen pushed a commit that referenced this pull request Jun 6, 2024
According to Babel tests feedback, remove some known ts AST nodes.
There are still many TS AST nodes that need to be deleted
@Boshen Boshen force-pushed the 06-06-feat_transformer_typescript_remove_typescript_ast_nodes branch from 900bc42 to 81aea1c Compare June 6, 2024 12:20
Boshen pushed a commit that referenced this pull request Jun 6, 2024
According to Babel tests feedback, remove some known ts AST nodes.
There are still many TS AST nodes that need to be deleted
@Boshen Boshen force-pushed the 06-06-feat_transformer_typescript_remove_typescript_ast_nodes branch from 81aea1c to cd4ae5a Compare June 6, 2024 12:25
According to Babel tests feedback, remove some known ts AST nodes.
There are still many TS AST nodes that need to be deleted
@Dunqing Dunqing force-pushed the 06-06-feat_transformer_typescript_remove_typescript_ast_nodes branch from cd4ae5a to e8a20f8 Compare June 7, 2024 05:04
@graphite-app graphite-app bot merged commit e8a20f8 into main Jun 7, 2024
@graphite-app graphite-app bot deleted the 06-06-feat_transformer_typescript_remove_typescript_ast_nodes branch June 7, 2024 05:08
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Boshen added a commit that referenced this pull request Jun 7, 2024
## [0.13.4] - 2024-06-07

### Features

- 5c8e16c coverage: Second transformer build does not print typescript
(#3561) (Dunqing)
- 646b993 coverage/transformer: Handle @jsx option (#3553) (Dunqing)
- a939ddd transformer/typescript: Remove more typescript ast nodes
(#3563) (Dunqing)
- e8a20f8 transformer/typescript: Remove typescript ast nodes (#3559)
(Dunqing)
- ee9a215 transformer/typescript: Handle namespace directive correctly
(#3532) (Dunqing)

### Bug Fixes

- affb2c8 codegen: Print indentation before directive (#3512) (Dunqing)
- f6939cb transformer: Store `react_importer` in `Bindings` in JSX
transform (#3551) (overlookmotel)
- 7982b93 transformer: Correct spans for JSX transform (#3549)
(overlookmotel)
- c00598b transformer: JSX set `reference_id` on refs to imports (#3524)
(overlookmotel)

### Performance

- 37cdc13 transformer: Faster checks if JSX plugin enabled (#3577)
(overlookmotel)
- 9f467b8 transformer: Avoid fragment update where possible (#3535)
(overlookmotel)
- ac394f0 transformer: JSX parse pragma only once (#3534)
(overlookmotel)

### Documentation

- 1d3c0d7 span: Add doc comments to `oxc_span::Span` (#3543) (Don Isaac)

### Refactor

- f2113ae transformer: Reduce cloning and referencing `Rc`s (#3576)
(overlookmotel)
- 0948124 transformer: Pass `Rc`s by value (#3550) (overlookmotel)
- e4d74ac transformer: Remove `update_fragment` from JSX transform
(#3541) (overlookmotel)
- 73b7864 transformer: Combine import and usage in JSX transform (#3540)
(overlookmotel)
- 6978269 transformer/typescript: Replace reference collector with
symbols references (#3533) (Dunqing)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant