refactor(coverage): use code without meta options in TypeScriptSuite#3552
Merged
graphite-app[bot] merged 1 commit intomainfrom Jun 6, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #3552 will improve performances by 6.11%Comparing Summary
Benchmarks breakdown
|
Dunqing
changed the title
Dunqing
force-pushed
the
06-06-refactor_coverage_use_without_meta_options_code_in_typescriptsuite
branch
2 times, most recently
from
372297e to
57d6a67
Compare
Contributor
Merge activity
|
…3552) The `@jsx: react` is a typescript option. The `Babel` typescript plugin handles @jsx as well, but this is different. `@jsx` in babel is a [pragma](https://babeljs.io/docs/babel-plugin-transform-react-jsx#pragma) option. So we should use code without these meta options to avoid Babel parsing `@jsx` incorrectly
Boshen
force-pushed
the
06-06-refactor_coverage_use_without_meta_options_code_in_typescriptsuite
branch
from
57d6a67 to
3ba2a93
Compare
graphite-app
bot
deleted the
06-06-refactor_coverage_use_without_meta_options_code_in_typescriptsuite
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@jsx: reactis a typescript option. TheBabeltypescript plugin handles @jsx as well, but this is different.@jsxin babel is a pragma option. So we should use code without these meta options to avoid Babel parsing@jsxincorrectly