Skip to content

Comments

improve(transformer): validate JSX import source option#3537

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-05-improve_transformer_validate_jsx_import_source_option
Jun 6, 2024
Merged

improve(transformer): validate JSX import source option#3537
graphite-app[bot] merged 1 commit intomainfrom
06-05-improve_transformer_validate_jsx_import_source_option

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jun 5, 2024

Validate import_source option for React JSX transform - disallow empty string.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jun 5, 2024
Copy link
Member Author

overlookmotel commented Jun 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review June 5, 2024 12:41
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 5, 2024

CodSpeed Performance Report

Merging #3537 will not alter performance

Comparing 06-05-improve_transformer_validate_jsx_import_source_option (4586f0b) with main (6506d08)

Summary

✅ 22 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 06-05-improve_transformer_validate_jsx_import_source_option branch from 9a9f40c to 1027b90 Compare June 5, 2024 13:12
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 6, 2024

Merge activity

Validate `import_source` option for React JSX transform - disallow empty string.
@Dunqing Dunqing force-pushed the 06-05-improve_transformer_improve_validation_of_jsx_pragma_options branch from fd098ad to 14c00a5 Compare June 6, 2024 03:20
@Dunqing Dunqing force-pushed the 06-05-improve_transformer_validate_jsx_import_source_option branch from cbd7c10 to 4586f0b Compare June 6, 2024 03:20
@Dunqing Dunqing changed the base branch from 06-05-improve_transformer_improve_validation_of_jsx_pragma_options to main June 6, 2024 03:26
@graphite-app graphite-app bot merged commit 4586f0b into main Jun 6, 2024
@graphite-app graphite-app bot deleted the 06-05-improve_transformer_validate_jsx_import_source_option branch June 6, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants