improve(transformer): validate JSX pragma options#3536
Merged
graphite-app[bot] merged 1 commit intomainfrom Jun 6, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #3536 will improve performances by 7.02%Comparing Summary
Benchmarks breakdown
|
overlookmotel
changed the title
overlookmotel
force-pushed
the
06-05-improve_transformer_improve_validation_of_jsx_pragma_options
branch
from
74510db to
f028a4a
Compare
This was referenced Jun 5, 2024
Boshen
approved these changes
Jun 5, 2024
This was referenced Jun 5, 2024
overlookmotel
force-pushed
the
06-05-improve_transformer_improve_validation_of_jsx_pragma_options
branch
from
f028a4a to
fd098ad
Compare
This was referenced Jun 6, 2024
Contributor
Merge activity
|
Validate React JSX `pragma` and `pragma_frag` options. Don't allow: * empty string * `foo.bar.qux` * `foo.` * `.bar` * `.` If options provided are invalid, raise an error and use the defaults. Also fast path the defaults.
Dunqing
force-pushed
the
06-05-improve_transformer_improve_validation_of_jsx_pragma_options
branch
from
fd098ad to
14c00a5
Compare
graphite-app
bot
deleted the
06-05-improve_transformer_improve_validation_of_jsx_pragma_options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate React JSX
pragmaandpragma_fragoptions. Don't allow:foo.bar.quxfoo..bar.If options provided are invalid, raise an error and use the defaults.
Also fast path the defaults.