perf(transformer): JSX parse pragma only once#3534
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #3534 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Jun 5, 2024
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Jun 7, 2024
## [0.13.4] - 2024-06-07 ### Features - 5c8e16c coverage: Second transformer build does not print typescript (#3561) (Dunqing) - 646b993 coverage/transformer: Handle @jsx option (#3553) (Dunqing) - a939ddd transformer/typescript: Remove more typescript ast nodes (#3563) (Dunqing) - e8a20f8 transformer/typescript: Remove typescript ast nodes (#3559) (Dunqing) - ee9a215 transformer/typescript: Handle namespace directive correctly (#3532) (Dunqing) ### Bug Fixes - affb2c8 codegen: Print indentation before directive (#3512) (Dunqing) - f6939cb transformer: Store `react_importer` in `Bindings` in JSX transform (#3551) (overlookmotel) - 7982b93 transformer: Correct spans for JSX transform (#3549) (overlookmotel) - c00598b transformer: JSX set `reference_id` on refs to imports (#3524) (overlookmotel) ### Performance - 37cdc13 transformer: Faster checks if JSX plugin enabled (#3577) (overlookmotel) - 9f467b8 transformer: Avoid fragment update where possible (#3535) (overlookmotel) - ac394f0 transformer: JSX parse pragma only once (#3534) (overlookmotel) ### Documentation - 1d3c0d7 span: Add doc comments to `oxc_span::Span` (#3543) (Don Isaac) ### Refactor - f2113ae transformer: Reduce cloning and referencing `Rc`s (#3576) (overlookmotel) - 0948124 transformer: Pass `Rc`s by value (#3550) (overlookmotel) - e4d74ac transformer: Remove `update_fragment` from JSX transform (#3541) (overlookmotel) - 73b7864 transformer: Combine import and usage in JSX transform (#3540) (overlookmotel) - 6978269 transformer/typescript: Replace reference collector with symbols references (#3533) (Dunqing) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently React JSX transform in classic mode with a custom
options.pragmavalue parsesoptions.pragmaon every JSX node, and inserts newAtoms into arena every time.This PR makes it parse
options.pragmaonly once at the start of the transform pass, and re-use the sameAtoms for each JSX node.