perf(transformer): React JSX reduce allocations#3522
Merged
graphite-app[bot] merged 1 commit intomainfrom Jun 4, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Jun 3, 2024
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #3522 will not alter performanceComparing Summary
|
Member
Author
|
In case you're is wondering why I'm bothering making these fairly small optimizations, this is just tidying up the code while I'm going through it figuring out the scopes stuff. |
This was referenced Jun 3, 2024
Contributor
Merge activity
|
React JSX transform was creating `CompactStr`s (which can involve heap allocations) and then converting them back to `Atom`s to insert into AST. This PR removes the intermediate `CompactStr`s and allocates strings directly into the arena without intermediate heap allocations.
Boshen
force-pushed
the
06-03-perf_transformer_react_jsx_reuse_same_atom_s
branch
from
8f0d568 to
f3a755c
Compare
Boshen
force-pushed
the
06-03-perf_transformer_react_jsx_reduce_allocations
branch
from
d6d50d4 to
91519d9
Compare
Boshen
changed the base branch from
06-03-perf_transformer_react_jsx_reuse_same_atom_s
to
main
graphite-app
bot
deleted the
06-03-perf_transformer_react_jsx_reduce_allocations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React JSX transform was creating
CompactStrs (which can involve heap allocations) and then converting them back toAtoms to insert into AST.This PR removes the intermediate
CompactStrs and allocates strings directly into the arena without intermediate heap allocations.