Skip to content

refactor(traverse): generate_uid return SymbolId#3520

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-03-refactor_traverse_generate_uid_return_symbolid_
Jun 4, 2024
Merged

refactor(traverse): generate_uid return SymbolId#3520
graphite-app[bot] merged 1 commit intomainfrom
06-03-refactor_traverse_generate_uid_return_symbolid_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jun 3, 2024

Preparatory step for setting correct SymbolId for identifiers added to AST in transformer.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Jun 3, 2024

@github-actions github-actions bot added the A-semantic Area - Semantic label Jun 3, 2024
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jun 3, 2024
@overlookmotel overlookmotel marked this pull request as ready for review June 3, 2024 16:27
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 3, 2024

CodSpeed Performance Report

Merging #3520 will not alter performance

Comparing 06-03-refactor_traverse_generate_uid_return_symbolid_ (7bbd3da) with main (837776e)

Summary

✅ 22 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 4, 2024

Merge activity

Preparatory step for setting correct `SymbolId` for identifiers added to AST in transformer.
@Boshen Boshen force-pushed the 06-03-refactor_traverse_generate_uid_return_symbolid_ branch from 5e5b1a0 to 7bbd3da Compare June 4, 2024 03:02
@graphite-app graphite-app bot merged commit 7bbd3da into main Jun 4, 2024
@graphite-app graphite-app bot deleted the 06-03-refactor_traverse_generate_uid_return_symbolid_ branch June 4, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant