Skip to content

Comments

refactor(codegen): print indentation before directive#3512

Merged
Boshen merged 2 commits intomainfrom
06-03-feat_codegen_remove_redundant_semicolons_from_the_directive_and_print_indentation
Jun 5, 2024
Merged

refactor(codegen): print indentation before directive#3512
Boshen merged 2 commits intomainfrom
06-03-feat_codegen_remove_redundant_semicolons_from_the_directive_and_print_indentation

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jun 3, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-codegen Area - Code Generation label Jun 3, 2024
Copy link
Member Author

Dunqing commented Jun 3, 2024

@Dunqing Dunqing changed the title feat(codegen): remove redundant semicolons from the directive and print indentation refactor(codegen): remove redundant semicolons from the directive and print indentation Jun 3, 2024
@Dunqing Dunqing force-pushed the 06-03-feat_codegen_remove_redundant_semicolons_from_the_directive_and_print_indentation branch from 6108338 to 83b42cd Compare June 3, 2024 02:51
@github-actions github-actions bot added the A-minifier Area - Minifier label Jun 3, 2024
@Dunqing Dunqing marked this pull request as ready for review June 3, 2024 02:52
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 3, 2024

CodSpeed Performance Report

Merging #3512 will not alter performance

Comparing 06-03-feat_codegen_remove_redundant_semicolons_from_the_directive_and_print_indentation (2f9ebcb) with main (c00598b)

Summary

✅ 22 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Jun 3, 2024

This doesn't look right, this changed the strings to directives.

@Dunqing
Copy link
Member Author

Dunqing commented Jun 3, 2024

This doesn't look right, this changed the strings to directives.

I've been rethinking this and it really isn't right. BTW, I noticed that swc is handled that way.

@Dunqing Dunqing changed the title refactor(codegen): remove redundant semicolons from the directive and print indentation refactor(codegen): print indentation before directive Jun 3, 2024
@Dunqing Dunqing force-pushed the 06-03-feat_codegen_remove_redundant_semicolons_from_the_directive_and_print_indentation branch from 11dc208 to ec68b14 Compare June 3, 2024 04:10
@Dunqing Dunqing marked this pull request as draft June 3, 2024 04:26
@Dunqing
Copy link
Member Author

Dunqing commented Jun 3, 2024

And then do some stuff in transformer to fix compiler/sourceMapValidationClasses.ts

@Dunqing Dunqing force-pushed the 06-03-feat_codegen_remove_redundant_semicolons_from_the_directive_and_print_indentation branch from ec68b14 to 2f9ebcb Compare June 5, 2024 06:22
@Dunqing Dunqing marked this pull request as ready for review June 5, 2024 06:23
@Boshen Boshen merged commit affb2c8 into main Jun 5, 2024
@Boshen Boshen deleted the 06-03-feat_codegen_remove_redundant_semicolons_from_the_directive_and_print_indentation branch June 5, 2024 08:32
Boshen added a commit that referenced this pull request Jun 7, 2024
## [0.13.4] - 2024-06-07

### Features

- 5c8e16c coverage: Second transformer build does not print typescript
(#3561) (Dunqing)
- 646b993 coverage/transformer: Handle @jsx option (#3553) (Dunqing)
- a939ddd transformer/typescript: Remove more typescript ast nodes
(#3563) (Dunqing)
- e8a20f8 transformer/typescript: Remove typescript ast nodes (#3559)
(Dunqing)
- ee9a215 transformer/typescript: Handle namespace directive correctly
(#3532) (Dunqing)

### Bug Fixes

- affb2c8 codegen: Print indentation before directive (#3512) (Dunqing)
- f6939cb transformer: Store `react_importer` in `Bindings` in JSX
transform (#3551) (overlookmotel)
- 7982b93 transformer: Correct spans for JSX transform (#3549)
(overlookmotel)
- c00598b transformer: JSX set `reference_id` on refs to imports (#3524)
(overlookmotel)

### Performance

- 37cdc13 transformer: Faster checks if JSX plugin enabled (#3577)
(overlookmotel)
- 9f467b8 transformer: Avoid fragment update where possible (#3535)
(overlookmotel)
- ac394f0 transformer: JSX parse pragma only once (#3534)
(overlookmotel)

### Documentation

- 1d3c0d7 span: Add doc comments to `oxc_span::Span` (#3543) (Don Isaac)

### Refactor

- f2113ae transformer: Reduce cloning and referencing `Rc`s (#3576)
(overlookmotel)
- 0948124 transformer: Pass `Rc`s by value (#3550) (overlookmotel)
- e4d74ac transformer: Remove `update_fragment` from JSX transform
(#3541) (overlookmotel)
- 73b7864 transformer: Combine import and usage in JSX transform (#3540)
(overlookmotel)
- 6978269 transformer/typescript: Replace reference collector with
symbols references (#3533) (Dunqing)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation A-minifier Area - Minifier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants