fix(linter): memorize visited block id in neighbors_filtered_by_edge_weight#3407
Merged
graphite-app[bot] merged 1 commit intomainfrom May 26, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
mysteryven
commented
May 25, 2024
CodSpeed Performance ReportMerging #3407 will not alter performanceComparing Summary
|
rzvxa
force-pushed
the
05-24-fix_linter_memorize_visited_block_id_in_neighbors_filtered_by_edge_weight_
branch
from
f068f7a to
170f5bb
Compare
Contributor
|
@mysteryven I didn't mean to force push here, I just stacked my PR on top of it, Didn't know it would result in this sorry about it. |
Contributor
|
Well now that the cat is out of the bag, I may as well go ahead and restack it properly doing the appropriate CFG changes. Sorry for the inconvenience! |
rzvxa
approved these changes
May 25, 2024
mysteryven
force-pushed
the
05-24-fix_linter_memorize_visited_block_id_in_neighbors_filtered_by_edge_weight_
branch
from
3e830d1 to
ee57dab
Compare
Contributor
Merge activity
|
Boshen
force-pushed
the
05-24-fix_linter_memorize_visited_block_id_in_neighbors_filtered_by_edge_weight_
branch
2 times, most recently
from
917f3ec to
c232751
Compare
Member
|
I screwed up the rebase 🤔 |
…_weight` (#3407) closes: #3396 we visit the same node too many times, I picked some result from run require-render-return rule on [timeserieseexploere.js](https://github.com/elastic/kibana/blob/main/x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js) ```bash NodeIndex(64): 368640, NodeIndex(67): 737280, NodeIndex(70): 2949120, NodeIndex(73): 5971968, NodeIndex(76): 11943936, NodeIndex(43): 184320, NodeIndex(71): 2985984, NodeIndex(65): 368640, NodeIndex(68): 1474560, NodeIndex(74): 5971968, NodeIndex(77): 23887872, NodeIndex(44): 184320, NodeIndex(41): 73728, NodeIndex(35): 36864, NodeIndex(66): 737280, NodeIndex(69): 1474560, NodeIndex(72): 2985984, NodeIndex(75): 11943936, ```
Boshen
force-pushed
the
05-24-fix_linter_memorize_visited_block_id_in_neighbors_filtered_by_edge_weight_
branch
from
c232751 to
5e06298
Compare
graphite-app
bot
deleted the
05-24-fix_linter_memorize_visited_block_id_in_neighbors_filtered_by_edge_weight_
branch
This was referenced May 28, 2024
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #3396
we visit the same node too many times, I picked some result from run require-render-return rule on timeserieseexploere.js
NodeIndex(64): 368640, NodeIndex(67): 737280, NodeIndex(70): 2949120, NodeIndex(73): 5971968, NodeIndex(76): 11943936, NodeIndex(43): 184320, NodeIndex(71): 2985984, NodeIndex(65): 368640, NodeIndex(68): 1474560, NodeIndex(74): 5971968, NodeIndex(77): 23887872, NodeIndex(44): 184320, NodeIndex(41): 73728, NodeIndex(35): 36864, NodeIndex(66): 737280, NodeIndex(69): 1474560, NodeIndex(72): 2985984, NodeIndex(75): 11943936,