Skip to content

Comments

feat(transformer): do not add self attribute in react/jsx plugin#3287

Merged
Boshen merged 2 commits intomainfrom
05-15-feat_transformer_do_not_add_self_attribute_in_react_jsx_plugin
May 15, 2024
Merged

feat(transformer): do not add self attribute in react/jsx plugin#3287
Boshen merged 2 commits intomainfrom
05-15-feat_transformer_do_not_add_self_attribute_in_react_jsx_plugin

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented May 15, 2024

follow-up: #3258.

@graphite-app
Copy link
Contributor

graphite-app bot commented May 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing force-pushed the 05-15-feat_transformer_do_not_add_self_attribute_in_react_jsx_plugin branch from 26a49d1 to 6c8c9e3 Compare May 15, 2024 07:05
@codspeed-hq
Copy link

codspeed-hq bot commented May 15, 2024

CodSpeed Performance Report

Merging #3287 will not alter performance

Comparing 05-15-feat_transformer_do_not_add_self_attribute_in_react_jsx_plugin (bd68b5b) with main (6128171)

Summary

✅ 27 untouched benchmarks

@Dunqing Dunqing marked this pull request as ready for review May 15, 2024 07:16
@Boshen
Copy link
Member

Boshen commented May 15, 2024

Can you restack this on top of main?

@Dunqing Dunqing force-pushed the 05-15-feat_transformer_do_not_add_self_attribute_in_react_jsx_plugin branch from 6c8c9e3 to 3c5a048 Compare May 15, 2024 09:01
@Dunqing Dunqing changed the base branch from 05-14-feat_transformer_typescript_report_error_relate_mts_cts_files to main May 15, 2024 09:01
@Dunqing Dunqing requested a review from Boshen May 15, 2024 09:16
@Boshen Boshen merged commit b9d69ad into main May 15, 2024
@Boshen Boshen deleted the 05-15-feat_transformer_do_not_add_self_attribute_in_react_jsx_plugin branch May 15, 2024 09:59
Boshen pushed a commit that referenced this pull request Jun 10, 2024
Remove a TODO comment where the do is done.

This was covered by #3258 and #3287.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants