Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

• feat(transformer/typescript): report error relate mts/cts files #3278 👈
• fix(transformer): do no add __self when the jsx is inside constructor #3258
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

CodSpeed Performance Report

Merging #3278 will not alter performance

_{Comparing 05-14-feat_transformer_typescript_report_error_relate_mts_cts_files (de0e69d) with main (5b2fc39)}

Summary

✅ 27 untouched benchmarks

This feels so weird thrown from the transformer, let me double check.

These are checker errors, we should throw them from the typescript checker.

From checker.ts:

    function checkAssertion(node: AssertionExpression, checkMode: CheckMode | undefined) {
        if (node.kind === SyntaxKind.TypeAssertionExpression) {
            const file = getSourceFileOfNode(node);
            if (file && fileExtensionIsOneOf(file.fileName, [Extension.Cts, Extension.Mts])) {
                grammarErrorOnNode(node, Diagnostics.This_syntax_is_reserved_in_files_with_the_mts_or_cts_extension_Use_an_as_expression_instead);
            }
        }
        return checkAssertionWorker(node, checkMode);
    }

    function checkGrammarArrowFunction(node: Node, file: SourceFile): boolean {
        if (!isArrowFunction(node)) {
            return false;
        }

        if (node.typeParameters && !(length(node.typeParameters) > 1 || node.typeParameters.hasTrailingComma || node.typeParameters[0].constraint)) {
            if (file && fileExtensionIsOneOf(file.fileName, [Extension.Mts, Extension.Cts])) {
                grammarErrorOnNode(node.typeParameters[0], Diagnostics.This_syntax_is_reserved_in_files_with_the_mts_or_cts_extension_Add_a_trailing_comma_or_explicit_constraint);
            }
        }

        const { equalsGreaterThanToken } = node;
        const startLine = getLineAndCharacterOfPosition(file, equalsGreaterThanToken.pos).line;
        const endLine = getLineAndCharacterOfPosition(file, equalsGreaterThanToken.end).line;
        return startLine !== endLine && grammarErrorOnNode(equalsGreaterThanToken, Diagnostics.Line_terminator_not_permitted_before_arrow);
    }

We don't run semantic check in the test suite, I wonder whether we should 😅

We don't run semantic check in the test suite, I wonder whether we should 😅

I initially wanted to throw the error in the semantic, but the transformer doesn't need semantic now.

Let's throw these in semantic checker, and ignore them from the transformer suite because they shouldn't be there ...

Let's throw these in semantic checker, and ignore them from the transformer suite because they shouldn't be there ...

The semantic doesn't have a source_path. Should we pass it in?

source_path

Why do we need source_path?

source_path

Why do we need source_path?

These errors only report in files with the .mts or .cts extension

source_path

Why do we need source_path?

These errors only report in files with the .mts or .cts extension

Oh, the information should be encoded in crates/oxc_span/src/source_type.rs

what are their official names and categories?

Oh, the information should be encoded in crates/oxc_span/src/source_type.rs

what are their official names and categories?

Seems they are no official names.

https://github.com/microsoft/TypeScript/blob/64d2eeea7b9c7f1a79edf42cb99f302535136a2e/src/compiler/checker.ts#L36039-L36047

https://github.com/microsoft/TypeScript/blob/4ece0a381be3d925b12b9a1626583578b8735805/src/compiler/moduleNameResolver.ts#L180-L187

Oh, the information should be encoded in crates/oxc_span/src/source_type.rs
what are their official names and categories?

Seems they are no official names.

https://github.com/microsoft/TypeScript/blob/64d2eeea7b9c7f1a79edf42cb99f302535136a2e/src/compiler/checker.ts#L36039-L36047

https://github.com/microsoft/TypeScript/blob/4ece0a381be3d925b12b9a1626583578b8735805/src/compiler/moduleNameResolver.ts#L180-L187

ModuleType: ESM / CJS