Skip to content

Comments

fix(ast): add type field to TS types for ObjectPattern etc#2670

Merged
Boshen merged 1 commit intomainfrom
03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc
Mar 11, 2024
Merged

fix(ast): add type field to TS types for ObjectPattern etc#2670
Boshen merged 1 commit intomainfrom
03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 10, 2024 •
edited
Loading

Fixes #2658 (details given in #2657 (comment)).

Add type fields to TS types for ObjectPattern, ArrayPattern etc which were missing previously.

@github-actions github-actions bot added the A-ast Area - AST label Mar 10, 2024
This was referenced Mar 10, 2024
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel mentioned this pull request Mar 10, 2024
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2670 will not alter performance

Comparing 03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc (6e078ea) with main (3c1e0db)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel mentioned this pull request Mar 10, 2024
Closed
@overlookmotel overlookmotel force-pushed the 03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive branch from 269b0be to 2cb5b4d Compare March 10, 2024 17:15
@overlookmotel overlookmotel force-pushed the 03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc branch from 1cc9e49 to 10f5260 Compare March 10, 2024 17:15
@Boshen Boshen force-pushed the 03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc branch from 10f5260 to 736471c Compare March 11, 2024 05:14
@Boshen Boshen changed the base branch from 03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive to main March 11, 2024 05:14
@Boshen Boshen force-pushed the 03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc branch from 736471c to 3a56ea5 Compare March 11, 2024 05:17
@Boshen Boshen changed the base branch from main to 03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive March 11, 2024 05:17
@Boshen Boshen force-pushed the 03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive branch from 2cb5b4d to 0cec2c0 Compare March 11, 2024 05:21
@Boshen Boshen force-pushed the 03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc branch from 3a56ea5 to 6edd8d1 Compare March 11, 2024 05:22
@Boshen Graphite App
Copy link
Member

Boshen commented Mar 11, 2024 •
edited
Loading

Merge activity

  • Mar 11, 1:38 AM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
  • Mar 11, 1:39 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 11, 1:42 AM EDT: @Boshen merged this pull request with Graphite.

Base automatically changed from 03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive to main March 11, 2024 05:38
@Boshen Boshen force-pushed the 03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc branch from 6edd8d1 to 6e078ea Compare March 11, 2024 05:38
@Boshen Boshen merged commit 3305734 into main Mar 11, 2024
@Boshen Boshen deleted the 03-10-fix_ast_add_type_field_to_TS_types_for_ObjectPattern_etc branch March 11, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ast Area - AST

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TS types for RestElement incorrect

2 participants

@overlookmotel @Boshen