Skip to content

Comments

refactor(ast): import Tsify to shorten code#2665

Merged
Boshen merged 1 commit intomainfrom
03-10-refactor_ast_import_Tsify_to_shorten_code
Mar 11, 2024
Merged

refactor(ast): import Tsify to shorten code#2665
Boshen merged 1 commit intomainfrom
03-10-refactor_ast_import_Tsify_to_shorten_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 10, 2024 •
edited
Loading

Pure refactor. Import tsify::Tsify in files that use it, so then shorten a load of:

- #[cfg_attr(feature = "wasm", derive(tsify::Tsify))]
+ #[cfg_attr(feature = "wasm", derive(Tsify))]

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST labels Mar 10, 2024
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel mentioned this pull request Mar 10, 2024
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2665 will not alter performance

Comparing 03-10-refactor_ast_import_Tsify_to_shorten_code (b8e542c) with main (d47f0e2)

Summary

✅ 29 untouched benchmarks

This was referenced Mar 10, 2024
Merged
Merged
Merged
Base automatically changed from 03-10-fix_ast_rename_TSIndexSignatureName_in_JSON_AST to main March 10, 2024 17:11
@overlookmotel overlookmotel force-pushed the 03-10-refactor_ast_import_Tsify_to_shorten_code branch from d0da8f4 to b8e542c Compare March 10, 2024 17:15
@Boshen Graphite App
Copy link
Member

Boshen commented Mar 11, 2024 •
edited
Loading

Merge activity

  • Mar 11, 12:36 AM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
  • Mar 11, 12:37 AM EDT: @Boshen merged this pull request with Graphite.

@Boshen Boshen merged commit cba1e2f into main Mar 11, 2024
@Boshen Boshen deleted the 03-10-refactor_ast_import_Tsify_to_shorten_code branch March 11, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ast Area - AST A-semantic Area - Semantic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @Boshen