Skip to content

refactor(formatter_core): remove thread-local scratch cache#24824

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-23-refactor_formatter_core_remove_thread-local_scratch_cache
Jul 23, 2026
Merged

refactor(formatter_core): remove thread-local scratch cache#24824
graphite-app[bot] merged 1 commit into
mainfrom
07-23-refactor_formatter_core_remove_thread-local_scratch_cache

Conversation

@leaysgur

@leaysgur leaysgur commented Jul 23, 2026

Copy link
Copy Markdown
Member

Revert #24583.

After re-measuring, I found no significant improvement. It is not worth the amount of code required.

Also, the fundamental issue is that the end-side formatter, rather than Oxfmt itself, is performing cross-file caching, which is an undesirable side effect.

@leaysgur
leaysgur requested a review from overlookmotel as a code owner July 23, 2026 05:44
@github-actions github-actions Bot added the A-formatter Area - Formatter label Jul 23, 2026
@leaysgur Graphite App

leaysgur commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2026
@leaysgur Graphite App

leaysgur commented Jul 23, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member Author

Merge activity

@leaysgur
refactor(formatter_core): remove thread-local scratch cache (#24824)
cee91dd 
Revert #24583.

After re-measuring, I found no significant improvement. It is not worth the amount of code required.

Also, the fundamental issue is that the end-side formatter, rather than Oxfmt itself, is performing cross-file caching, which is an undesirable side effect.
@graphite-app
graphite-app Bot force-pushed the 07-23-refactor_formatter_core_remove_thread-local_scratch_cache branch from 75af3b0 to cee91dd Compare July 23, 2026 05:48
@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing 07-23-refactor_formatter_core_remove_thread-local_scratch_cache (75af3b0) with main (fe3d170)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (4b6a878) during the generation of this report, so fe3d170 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@graphite-app
graphite-app Bot merged commit cee91dd into main Jul 23, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2026
@graphite-app
graphite-app Bot deleted the 07-23-refactor_formatter_core_remove_thread-local_scratch_cache branch July 23, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur