Skip to content

perf(formatter_core): bound the thread-local scratch cache#24793

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-22-perf_formatter_core_bound_the_thread-local_scrach_cache
Jul 22, 2026
Merged

perf(formatter_core): bound the thread-local scratch cache#24793
graphite-app[bot] merged 1 commit into
mainfrom
07-22-perf_formatter_core_bound_the_thread-local_scrach_cache

Conversation

@leaysgur

@leaysgur leaysgur commented Jul 22, 2026

Copy link
Copy Markdown
Member

Measures to address this.

NOTE: checked-in vectors keep their high-water capacity for the thread's lifetime

The 8 MB covers the largest file (checker.ts) that is likely to be created and formatted manually.

leaysgur commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Jul 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 19 skipped benchmarks1


Comparing 07-22-perf_formatter_core_bound_the_thread-local_scrach_cache (0815791) with 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap (a1da8be)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur changed the title perf(formatter_core): bound the thread-local scrach cache perf(formatter_core): bound the thread-local scratch cache Jul 22, 2026
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jul 22, 2026
@graphite-app

graphite-app Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Merge activity

Measures to address this.

> NOTE: checked-in vectors keep their high-water capacity for the thread's lifetime

The 8 MB covers the largest file (checker.ts) that is likely to be created and formatted manually.
@graphite-app
graphite-app Bot force-pushed the 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap branch from a1da8be to a5f7b15 Compare July 22, 2026 06:33
@graphite-app
graphite-app Bot force-pushed the 07-22-perf_formatter_core_bound_the_thread-local_scrach_cache branch from 0815791 to bb73b23 Compare July 22, 2026 06:34
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 22, 2026
Base automatically changed from 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap to main July 22, 2026 06:40
@graphite-app
graphite-app Bot merged commit bb73b23 into main Jul 22, 2026
32 checks passed
@graphite-app
graphite-app Bot deleted the 07-22-perf_formatter_core_bound_the_thread-local_scrach_cache branch July 22, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant