docs(estree): document custom serializers for ImportMeta and NewTarget#24777
Merged
graphite-app[bot] merged 1 commit intoJul 22, 2026
Conversation
This was referenced Jul 21, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
om/07-21-refactor_estree_re-order_serializer_code_for_importmeta_and_newtarget_
branch
from
July 21, 2026 19:47
f370dd0 to
94c1550
Compare
overlookmotel
force-pushed
the
om/07-21-docs_estree_document_custom_serializers_for_importmeta_and_newtarget_
branch
from
July 21, 2026 19:47
079b844 to
2574d6b
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
overlookmotel
marked this pull request as ready for review
July 21, 2026 19:50
overlookmotel
requested review from
camc314 and
Copilot
and removed request for
Copilot
July 21, 2026 19:50
graphite-app
Bot
force-pushed
the
om/07-21-refactor_estree_re-order_serializer_code_for_importmeta_and_newtarget_
branch
from
July 21, 2026 19:54
94c1550 to
1a76b4c
Compare
graphite-app
Bot
force-pushed
the
om/07-21-docs_estree_document_custom_serializers_for_importmeta_and_newtarget_
branch
from
July 21, 2026 19:54
2574d6b to
34d7c4d
Compare
overlookmotel
force-pushed
the
om/07-21-refactor_estree_re-order_serializer_code_for_importmeta_and_newtarget_
branch
from
July 21, 2026 19:57
1a76b4c to
eff8b50
Compare
overlookmotel
force-pushed
the
om/07-21-docs_estree_document_custom_serializers_for_importmeta_and_newtarget_
branch
from
July 21, 2026 19:57
34d7c4d to
e76bd4d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Documentation-only follow-up to the MetaProperty split (#24557), adding rustdoc explaining the custom ESTree serialization helpers for ImportMeta and NewTarget in the AST serializer layer.
Changes:
- Document how the
metafield is synthesized during ESTree serialization forImportMetaandNewTarget. - Document how the
propertyfield is synthesized during ESTree serialization forImportMetaandNewTarget.
overlookmotel
force-pushed
the
om/07-21-refactor_estree_re-order_serializer_code_for_importmeta_and_newtarget_
branch
from
July 21, 2026 20:09
eff8b50 to
d81abc3
Compare
overlookmotel
force-pushed
the
om/07-21-docs_estree_document_custom_serializers_for_importmeta_and_newtarget_
branch
from
July 21, 2026 20:09
e76bd4d to
2c6bde9
Compare
camc314
approved these changes
Jul 22, 2026
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
om/07-21-refactor_estree_re-order_serializer_code_for_importmeta_and_newtarget_
branch
from
July 22, 2026 08:11
d81abc3 to
d68e9fd
Compare
graphite-app
Bot
force-pushed
the
om/07-21-docs_estree_document_custom_serializers_for_importmeta_and_newtarget_
branch
from
July 22, 2026 08:12
2c6bde9 to
b539e74
Compare
Base automatically changed from
om/07-21-refactor_estree_re-order_serializer_code_for_importmeta_and_newtarget_
to
main
July 22, 2026 08:17
graphite-app
Bot
deleted the
om/07-21-docs_estree_document_custom_serializers_for_importmeta_and_newtarget_
branch
July 22, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #24557. Docs-only change. Add doc comments to custom serializers for
ImportMetaandNewTarget.