fix(estree): handle empty spans serializing ImportMeta and NewTarget#24775
Merged
graphite-app[bot] merged 1 commit intoJul 22, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 21, 2026
overlookmotel
marked this pull request as ready for review
July 21, 2026 19:46
overlookmotel
force-pushed
the
om/07-21-fix_estree_handle_empty_spans_serializing_importmeta_and_newtarget_
branch
from
July 21, 2026 19:47
c4284d7 to
35ae343
Compare
github-actions
Bot
added
A-linter
Merging this PR will not alter performance
Comparing 
Footnotes
|
graphite-app
Bot
changed the base branch from
om/07-21-perf_estree_avoid_ident_hash_calculations_when_serializing
to
graphite-base/24775
July 21, 2026 19:48
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens ESTree serialization/deserialization for the recently introduced ImportMeta and NewTarget AST nodes by correctly handling the “empty span” case (SPAN), which can occur when nodes are synthesized during transforms and later serialized.
Changes:
- Update ESTree serialization of
ImportMeta/NewTargetidentifier subfields to avoid manufacturing non-empty spans when the node span isSPAN. - Update the associated
raw_desersnippets to avoid deriving offsets from empty spans. - Import
SPANinto the serializer module to enable explicit empty-span checks.
graphite-app
Bot
force-pushed
the
graphite-base/24775
branch
from
July 21, 2026 19:53
7d185b5 to
b287f29
Compare
graphite-app
Bot
force-pushed
the
om/07-21-fix_estree_handle_empty_spans_serializing_importmeta_and_newtarget_
branch
from
July 21, 2026 19:53
35ae343 to
a18c4bc
Compare
graphite-app
Bot
force-pushed
the
om/07-21-fix_estree_handle_empty_spans_serializing_importmeta_and_newtarget_
branch
from
July 21, 2026 19:54
a18c4bc to
fc31e79
Compare
camc314
approved these changes
Jul 21, 2026
overlookmotel
force-pushed
the
om/07-21-fix_estree_handle_empty_spans_serializing_importmeta_and_newtarget_
branch
2 times, most recently
from
July 21, 2026 20:09
359519f to
6ab74a7
Compare
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
om/07-21-fix_estree_handle_empty_spans_serializing_importmeta_and_newtarget_
branch
from
July 22, 2026 08:06
6ab74a7 to
e80574f
Compare
graphite-app
Bot
deleted the
om/07-21-fix_estree_handle_empty_spans_serializing_importmeta_and_newtarget_
branch
July 22, 2026 08:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #24557. Handle when
ImportMeta/NewTargethas an empty span (SPAN). This code path is not exercised at present, but it seems a good idea to be prepared for when we may serialize AST after transformation.