Skip to content

perf(estree): avoid ident hash calculations when serializing#24774

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/07-21-perf_estree_avoid_ident_hash_calculations_when_serializing
Jul 21, 2026
Merged

perf(estree): avoid ident hash calculations when serializing#24774
graphite-app[bot] merged 1 commit into
mainfrom
om/07-21-perf_estree_avoid_ident_hash_calculations_when_serializing

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Follow-on after #24557. Avoid runtime construction of Idents (which involves runtime hash calculation) in custom serializers for ImportMeta and NewTarget. Instead use static_ident! which calculates the hash at compile time.

@github-actions github-actions Bot added the A-ast Area - AST label Jul 21, 2026
@overlookmotel Graphite App

overlookmotel commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 21, 2026
Merged
Merged
Merged
@overlookmotel
overlookmotel marked this pull request as ready for review July 21, 2026 19:43
@overlookmotel
overlookmotel requested review from camc314 and Copilot and removed request for Copilot July 21, 2026 19:43
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 21, 2026
@camc314 Graphite App

camc314 commented Jul 21, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
perf(estree): avoid ident hash calculations when serializing (#24774)
b287f29 
Follow-on after #24557. Avoid runtime construction of `Ident`s (which involves runtime hash calculation) in custom serializers for `ImportMeta` and `NewTarget`. Instead use `static_ident!` which calculates the hash at compile time.
@graphite-app
graphite-app Bot force-pushed the om/07-21-perf_estree_avoid_ident_hash_calculations_when_serializing branch from 7d185b5 to b287f29 Compare July 21, 2026 19:48
@codspeed-hq

codspeed-hq Bot commented Jul 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing om/07-21-perf_estree_avoid_ident_hash_calculations_when_serializing (7d185b5) with main (baf022d)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (935e9c8) during the generation of this report, so baf022d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@graphite-app
graphite-app Bot merged commit b287f29 into main Jul 21, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 21, 2026
@graphite-app
graphite-app Bot deleted the om/07-21-perf_estree_avoid_ident_hash_calculations_when_serializing branch July 21, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-ast Area - AST

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314