Skip to content

refactor(ecmascript): expose engine targets to side effects#24742

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/side-effect-engine-targets
Jul 21, 2026
Merged

refactor(ecmascript): expose engine targets to side effects#24742
graphite-app[bot] merged 1 commit into
mainfrom
codex/side-effect-engine-targets

Conversation

@Dunqing

@Dunqing Dunqing commented Jul 21, 2026

Copy link
Copy Markdown
Member

PR stack (2 of 3)

  1. refactor(ecmascript)!: gate analysis APIs #24739
  2. refactor(ecmascript): expose engine targets to side effects #24742 (this PR)
  3. fix(minifier): preserve RegExp feature detection #24712

Review #24739 first. This PR is based on its branch, so GitHub shows only the engine-target plumbing.

Stacked on #24739, which introduces the side_effects and constant_evaluation feature boundary for oxc_ecmascript.

Side-effect analysis sometimes needs to know whether runtime syntax is supported by every configured engine. MayHaveSideEffectsContext currently has no access to target information, while EngineTargets::has_feature is intentionally permissive about missing compatibility data because it answers whether a transformation is needed.

MayHaveSideEffectsContext::engine_targets() exposes the configured targets through a general-purpose accessor. Its default is None, so consumers without target information remain conservative, while the minifier supplies its existing CompressOptions::target.

EngineTargets::supports_es_feature provides the corresponding strict capability query. Every configured engine must have compatibility data and meet the required version; empty targets and missing rows are not treated as proof of support. The existing transformation-oriented has_feature behavior remains unchanged.

Because oxc_linter enables side_effects, this also adds oxc_compat to the oxlint and language-server build graphs. It does not change side-effect decisions by itself; #24712 consumes the new capability for target-aware RegExp validation.

Verified with all oxc_compat tests, the no-feature/side_effects/constant_evaluation oxc_ecmascript matrix, a minifier check, formatting, and Clippy.

Implemented with AI assistance (OpenAI Codex and Claude). The contributor remains responsible for reviewing, understanding, and maintaining these changes.

@github-actions github-actions Bot added the A-minifier Area - Minifier label Jul 21, 2026

Dunqing commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Jul 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 9 skipped benchmarks1


Comparing codex/side-effect-engine-targets (4994d9b) with codex/ecmascript-analysis-features (602e7f4)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on codex/ecmascript-analysis-features (bdce820) during the generation of this report, so d3fdabb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dunqing
Dunqing force-pushed the codex/side-effect-engine-targets branch 2 times, most recently from 9c04aa6 to 96987da Compare July 21, 2026 05:21
@Dunqing
Dunqing marked this pull request as ready for review July 21, 2026 05:32
@Dunqing
Dunqing requested a review from sapphi-red July 21, 2026 05:46
@Dunqing

Dunqing commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

After this, MayHaveSideEffectsContext can support targets-aware side-effect checks.

@Dunqing
Dunqing force-pushed the codex/ecmascript-analysis-features branch from 602e7f4 to bdce820 Compare July 21, 2026 08:07
@Dunqing
Dunqing force-pushed the codex/side-effect-engine-targets branch from 96987da to 4994d9b Compare July 21, 2026 08:07
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jul 21, 2026
@graphite-app

graphite-app Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Merge activity

> **PR stack (2 of 3)**
> 1. #24739
> 2. **#24742 (this PR)**
> 3. #24712
>
> Review #24739 first. This PR is based on its branch, so GitHub shows only the engine-target plumbing.

Stacked on #24739, which introduces the `side_effects` and `constant_evaluation` feature boundary for `oxc_ecmascript`.

Side-effect analysis sometimes needs to know whether runtime syntax is supported by every configured engine. `MayHaveSideEffectsContext` currently has no access to target information, while `EngineTargets::has_feature` is intentionally permissive about missing compatibility data because it answers whether a transformation is needed.

`MayHaveSideEffectsContext::engine_targets()` exposes the configured targets through a general-purpose accessor. Its default is `None`, so consumers without target information remain conservative, while the minifier supplies its existing `CompressOptions::target`.

`EngineTargets::supports_es_feature` provides the corresponding strict capability query. Every configured engine must have compatibility data and meet the required version; empty targets and missing rows are not treated as proof of support. The existing transformation-oriented `has_feature` behavior remains unchanged.

Because `oxc_linter` enables `side_effects`, this also adds `oxc_compat` to the oxlint and language-server build graphs. It does not change side-effect decisions by itself; #24712 consumes the new capability for target-aware RegExp validation.

Verified with all `oxc_compat` tests, the no-feature/`side_effects`/`constant_evaluation` `oxc_ecmascript` matrix, a minifier check, formatting, and Clippy.

Implemented with AI assistance (OpenAI Codex and Claude). The contributor remains responsible for reviewing, understanding, and maintaining these changes.
graphite-app Bot pushed a commit that referenced this pull request Jul 21, 2026
> **PR stack (1 of 3)**
> 1. **#24739 (this PR)**
> 2. #24742
> 3. #24712
>
> Review and merge in this order.

The `oxc_ecmascript` crate currently compiles constant evaluation and side-effect analysis for every consumer, even when a consumer only needs the small shared ECMAScript value primitives. This makes optional analysis code and its dependencies part of unrelated builds.

This introduces two explicit features:

- `side_effects` enables side-effect analysis and its RegExp support.
- `constant_evaluation` enables constant evaluation and implies `side_effects`, because side-effect analysis uses constant folding for several purity decisions.

`ConstantValue`, `ValueType`, and `DetermineValueType` move to feature-independent root modules so `GlobalContext` remains available without either analysis feature. Existing paths through `constant_evaluation` remain re-exported when that feature is enabled.

This is a prerequisite for #24742, which exposes engine targets to side-effect analysis without making compatibility data part of every `oxc_ecmascript` consumer.

This is a breaking Cargo feature change for direct consumers of `oxc_ecmascript`: code using side-effect analysis or constant evaluation must enable the corresponding feature.

Verified locally with the no-feature, `side_effects`, and `constant_evaluation` configurations, crate tests, dependent linter and minifier tests, rustdoc with warnings denied, and `just ready`. The release oxlint binary on this commit is 13,350,096 bytes.

Implemented with AI assistance (OpenAI Codex and Claude). The contributor remains responsible for reviewing, understanding, and maintaining these changes.
@graphite-app
graphite-app Bot force-pushed the codex/ecmascript-analysis-features branch from bdce820 to 9a48d23 Compare July 21, 2026 14:15
@graphite-app
graphite-app Bot requested a review from camc314 as a code owner July 21, 2026 14:15
@graphite-app
graphite-app Bot force-pushed the codex/side-effect-engine-targets branch from 4994d9b to 01c3611 Compare July 21, 2026 14:16
graphite-app Bot pushed a commit that referenced this pull request Jul 21, 2026
> **PR stack (3 of 3)**
> 1. #24739
> 2. #24742
> 3. **#24712 (this PR)**
>
> Review #24739 and #24742 first. This PR is based on #24742, so GitHub shows only the RegExp behavior change.

Stacked on #24742, which exposes strict engine-target capabilities to side-effect analysis.

RegExp constructor calls used for engine feature detection were removed by DCE when their pattern was valid according to the current Oxc RegExp parser. A pattern can be valid at build time but still throw a `SyntaxError` on the configured runtime, so removing the call changes the result of surrounding `try`/`catch` checks.

RegExp purity now requires both syntactic validity and support from every configured target. Consumers without concrete targets remain conservative, while an explicit target allows the minifier to remove constructors known to be safe for those engines.

Target-independent flag validation and pattern compatibility checks now live in `oxc_regular_expression`; side-effect analysis only maps target support to unsupported flags and patterns. String patterns, modern flags, named groups, property escapes, lookbehind, modifiers, invalid flags, and lone-surrogate strings are covered. A RegExp literal with replacement flags is removable only when the target supports both those flags and the dedicated `ES2015RegExpConstructorCanAlterFlags` compatibility feature. Explicitly targeting `esnext` opts into current features.

## Example

Input:

```js
export function supportsUnicodeRegExp() {
  try {
    new RegExp("\\p{Ll}", "u");
    return true;
  } catch {
    return false;
  }
}
```

Before:

```js
export function supportsUnicodeRegExp() {
  try {
    return true;
  } catch {
    return false;
  }
}
```

After:

```js
export function supportsUnicodeRegExp() {
  try {
    new RegExp("\\p{Ll}", "u");
    return true;
  } catch {
    return false;
  }
}
```

Verified with all `oxc_regular_expression`, `oxc_compat`, `oxc_ecmascript`, and `oxc_minifier` tests; the no-feature/`side_effects`/`constant_evaluation` `oxc_ecmascript` matrix; affected-crate clippy; formatting; and diff checks.

Fixes rolldown/rolldown#10279.

Implemented with AI assistance (OpenAI Codex and Claude). The contributor remains responsible for reviewing, understanding, and submitting these changes under the repository AI usage policy.
Base automatically changed from codex/ecmascript-analysis-features to main July 21, 2026 14:20
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 21, 2026
@graphite-app
graphite-app Bot merged commit 01c3611 into main Jul 21, 2026
32 checks passed
@graphite-app
graphite-app Bot deleted the codex/side-effect-engine-targets branch July 21, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants