Skip to content

fix(minifier): avoid incorrect logical assignment transformation when base object may be mutated#24718

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-20-fix_minifier_avoid_incorrect_logical_assignment_transformation_when_base_object_may_be_mutated
Jul 21, 2026
Merged

fix(minifier): avoid incorrect logical assignment transformation when base object may be mutated#24718
graphite-app[bot] merged 1 commit into
mainfrom
07-20-fix_minifier_avoid_incorrect_logical_assignment_transformation_when_base_object_may_be_mutated

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Similar to #16802 but for cases without the returned value.

@sapphi-red sapphi-red mentioned this pull request Jul 20, 2026
Merged
@github-actions github-actions Bot added the A-minifier Area - Minifier label Jul 20, 2026
@sapphi-red sapphi-red mentioned this pull request Jul 20, 2026
Merged
@sapphi-red Graphite App

sapphi-red commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red
sapphi-red marked this pull request as ready for review July 20, 2026 10:36
@codspeed-hq

codspeed-hq Bot commented Jul 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing 07-20-fix_minifier_avoid_incorrect_logical_assignment_transformation_when_base_object_may_be_mutated (11b7422) with main (0e9b460)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 07-20-feat_minifier_merge_combined_assign_expression_in_conditional_expression (c6ccfb2) during the generation of this report, so main (0e9b460) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Dunqing Dunqing added the run-monitor-oxc Add to a PR to dispatch oxc-project/monitor-oxc CI against it label Jul 20, 2026
@oxc-guard

oxc-guard Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Monitor Oxc

Commit: 11b74225d07f

suite result
Test262 ✅
Build ✅
Runtime Bundles ✅
Isolated Declarations ✅
Uglify Corpus ✅
(transformer) ✅
(dce) ✅
(whitespace) ✅
(formatter_dcr) ✅
(codegen) ✅
(mangler) ❌
(formatter) ❌
(compressor) ✅
Runtime (solid) ✅
Runtime (svelte) ✅
Runtime (es-toolkit) ✅
Runtime (zod) ✅
Runtime (vue) ✅

@oxc-guard oxc-guard Bot removed the run-monitor-oxc Add to a PR to dispatch oxc-project/monitor-oxc CI against it label Jul 20, 2026
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jul 21, 2026
@Dunqing Graphite App

Dunqing commented Jul 21, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member

Merge activity

@sapphi-red
fix(minifier): avoid incorrect logical assignment transformation when…
d85276c 
… base object may be mutated (#24718)

Similar to #16802 but for cases without the returned value.
@graphite-app
graphite-app Bot force-pushed the 07-20-feat_minifier_merge_combined_assign_expression_in_conditional_expression branch from c6ccfb2 to 87823d0 Compare July 21, 2026 03:31
@graphite-app
graphite-app Bot force-pushed the 07-20-fix_minifier_avoid_incorrect_logical_assignment_transformation_when_base_object_may_be_mutated branch from 11b7422 to d85276c Compare July 21, 2026 03:32
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 21, 2026
Base automatically changed from 07-20-feat_minifier_merge_combined_assign_expression_in_conditional_expression to main July 21, 2026 03:36
@graphite-app
graphite-app Bot merged commit d85276c into main Jul 21, 2026
31 checks passed
@graphite-app
graphite-app Bot deleted the 07-20-fix_minifier_avoid_incorrect_logical_assignment_transformation_when_base_object_may_be_mutated branch July 21, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing approved these changes
@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-minifier Area - Minifier

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Dunqing