feat(ast): allow `NONE` to be passed to AST builder methods where `Option<ArenaVec>` is expected by overlookmotel · Pull Request #24629 · oxc-project/oxc

overlookmotel · 2026-07-17T13:29:08Z

NONE is used for passing to AstBuilder methods which expect an Option<'a, Box<'a, SomeAstNode<'a>>>.

Extend support to Option<'a, Vec<'a, SomeAstNode<'a>>> too. We don't use this currently, but it could be useful in future, and is very little code.

overlookmotel · 2026-07-17T13:29:33Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Extends the NONE marker type used with AstBuilder to also support builder methods that take Option<ArenaVec<'a, T>>, enabling callers to write NONE instead of verbose None::<...> type annotations.

Changes:

Import ArenaVec into the AST builder module.
Add FromIn<'a, NONE> for Option<ArenaVec<'a, T>> so NONE converts to None for optional arena vectors.
Update the NONE rustdoc to describe the newly supported Option<Vec> case (with a small doc formatting fix recommended in a comment).

codspeed-hq · 2026-07-17T13:36:26Z

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 9 skipped benchmarks¹

_{Comparing om/07-17-feat_ast_allow_none_to_be_passed_to_ast_builder_methods_where_option_arenavec_is_expected (94f99b3) with main (2338c13)²}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (18ce449) during the generation of this report, so 2338c13 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2026-07-17T13:49:04Z

Merge activity

Jul 17, 1:49 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Jul 17, 2:04 PM UTC: Merged by the Graphite merge queue.

…tion<ArenaVec>` is expected (#24629) `NONE` is used for passing to `AstBuilder` methods which expect an `Option<'a, Box<'a, SomeAstNode<'a>>>`. Extend support to `Option<'a, Vec<'a, SomeAstNode<'a>>>` too. We don't use this currently, but it could be useful in future, and is very little code.

### 💥 BREAKING CHANGES - 54cc121 ast: [**BREAKING**] Split `MetaProperty` into `ImportMeta` and `NewTarget` (#24557) (camc314) ### 🚀 Features - 4c71560 parser: More friendly error for spread element in dynamic imports (#24705) (sapphi-red) - 7b045cd minfier: Drop last break from last switch case (#24673) (Armano) - 7d3c178 minifier: Remove unreachable recursive functions (#24125) (Dunqing) - 94f99b3 ast: Allow `NONE` to be passed to AST builder methods where `Option<ArenaVec>` is expected (#24629) (overlookmotel) - 77230c5 ast: Accept arrays for `ArenaVec` params of AST builder methods (#24621) (overlookmotel) - f08b152 allocator: Implement `FromIn` for array to `Vec` conversion (#24620) (overlookmotel) - 2338c13 track-memory-allocations: Track heap deallocs, alloc bytes, and peak growth (#24619) (Boshen) - 7aa4739 syntax,transformer: Move JSX entity decoder to `oxc_syntax` (#24617) (camc314) - 2b097c4 str: Export `Str` as `ArenaStr` (#24604) (overlookmotel) - 3acf4c1 minifier: Expand switch optimiation to remove empty cases (#24520) (Armano) - 129b759 parser: Improve diagnostics for unparenthesized LHS on exponential expr (#24569) (camc314) - 4d0c601 minifier: Fold arithmetic over undefined and null operands (#24485) (Dunqing) - 91541dd minifier: Drop empty switch statements (#24527) (Armano) - d05224d ast_visit: Generate VisitJs visitor that skips TypeScript type-space (#24499) (Boshen) - 3d22307 parser: Add `ParseOptions::enable_ident_hashes` (#24491) (Boshen) ### 🐛 Bug Fixes - 64c2241 minifier: Align class heritage removal with assumptions (#24533) (Dunqing) - 48b59f4 parser: Span ambient generator diagnostics (#24711) (camc314) - e750a82 ecmascript: Fix false negative for may_have_side_effects on dynamic property access (#24709) (sapphi-red) - f145d73 minifier: Guard reordered identifier reads (#24698) (Dunqing) - a2ef382 isolated-declarations: Reject `window.Symbol` as global symbol reference (#24689) (camc314) - b1bcf72 minifier: Invalidate facts for redeclared bindings (#24658) (Dunqing) - 921b834 minifier: Don't treat a conditionally-assigned var as write-once (#24650) (Dunqing) - 061af1f minifier: Avoid stale pure function summaries (#24636) (Dunqing) - 40c2f43 allocator: `Vec::from_array_in` do not allocate zero-length array (#24628) (overlookmotel) - 70994ae codegen: Preserve comments before expression operands (#24510) (Dunqing) - 7b4baff parser: Reject new import member access (#23459) (camc314) - 128b385 minifier: Clippy warning with no-debug-assertions (#24547) (camc314) - 8421feb parser: Use first `as` span for imported name (#24537) (leaysgur) - c517aa0 parser: Reject invalid accessor assertions (#24504) (camc314) ### ⚡ Performance - 884d9eb parser: Pre-size cover-grammar assignment target buffers (#24683) (Boshen) - d3f07a0 diagnostics: Box OxcDiagnosticInner to reduce binary size (#24665) (Boshen) - bcc9de0 parser: Defer diagnostic creation until parse exit (#24663) (Boshen) - c35d8ab allocator: Mark `ReplaceWith` panic path cold (#24515) (camc314) - ba65790 semantic, allocator: Branchless `clone_in` for semantic IDs (#24564) (overlookmotel) - 747feec parser: Build AST nodes with the AST builder instead of cloning (#24540) (Boshen) - ba35a0d react_compiler: Use IndexVec for dense id-keyed maps (#24549) (Boshen) - b685062 react_compiler: Keep small hot-path collections inline (#24514) (Marius Schulz) - a149e95 transformer: Outline rare expression exits (#24512) (camc314) - 7808a6e react_compiler: Make aliasing effects cheap to intern and clone (#24506) (Marius Schulz) - 3a36f2a react_compiler: Store AbstractValue reasons as a u16 bitmask (#24480) (Boshen) - 1c96753 react_compiler: Use FxHashMap for the lookup-only aliasing node map (#24490) (Boshen) Co-authored-by: Cameron <[email protected]>

github-actions Bot added the A-ast Area - AST label Jul 17, 2026

This was referenced Jul 17, 2026

fix(allocator): Vec::from_array_in do not allocate zero-length array #24628

Merged

refactor(react_compiler): shorten code by using NONE #24630

Merged

overlookmotel marked this pull request as ready for review July 17, 2026 13:30

Copilot AI review requested due to automatic review settings July 17, 2026 13:30

overlookmotel self-assigned this Jul 17, 2026

Copilot started reviewing on behalf of overlookmotel July 17, 2026 13:31 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread crates/oxc_ast/src/builder/mod.rs

overlookmotel force-pushed the om/07-17-feat_ast_allow_none_to_be_passed_to_ast_builder_methods_where_option_arenavec_is_expected branch from 160ae9f to 993d30d Compare July 17, 2026 13:39

camc314 approved these changes Jul 17, 2026

View reviewed changes

graphite-app Bot force-pushed the om/07-17-refactor_react_compiler_shorten_code_constructing_objectpropertykind_ branch from 6e5ba03 to 18ce449 Compare July 17, 2026 13:54

graphite-app Bot requested a review from Dunqing as a code owner July 17, 2026 13:54

graphite-app Bot force-pushed the om/07-17-feat_ast_allow_none_to_be_passed_to_ast_builder_methods_where_option_arenavec_is_expected branch from 993d30d to 94f99b3 Compare July 17, 2026 13:54

Base automatically changed from om/07-17-refactor_react_compiler_shorten_code_constructing_objectpropertykind_ to main July 17, 2026 14:02

graphite-app Bot merged commit 94f99b3 into main Jul 17, 2026
41 checks passed

graphite-app Bot deleted the om/07-17-feat_ast_allow_none_to_be_passed_to_ast_builder_methods_where_option_arenavec_is_expected branch July 17, 2026 14:04

oxc-guard Bot mentioned this pull request Jul 20, 2026

release(crates): oxc v0.141.0 #24714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(ast): allow `NONE` to be passed to AST builder methods where `Option<ArenaVec>` is expected#24629

feat(ast): allow `NONE` to be passed to AST builder methods where `Option<ArenaVec>` is expected#24629
graphite-app[bot] merged 1 commit into
mainfrom
om/07-17-feat_ast_allow_none_to_be_passed_to_ast_builder_methods_where_option_arenavec_is_expected

overlookmotel commented Jul 17, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Jul 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

graphite-app Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

overlookmotel commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codspeed-hq Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

graphite-app Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Jul 17, 2026 •

edited

Loading

overlookmotel commented Jul 17, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 17, 2026 •

edited

Loading

graphite-app Bot commented Jul 17, 2026 •

edited

Loading