Skip to content

refactor(parser): shorten code constructing ObjectPropertyKind#24626

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/07-17-refactor_parser_shorten_code_constructing_objectpropertykind_
Jul 17, 2026
Merged

refactor(parser): shorten code constructing ObjectPropertyKind#24626
graphite-app[bot] merged 1 commit into
mainfrom
om/07-17-refactor_parser_shorten_code_constructing_objectpropertykind_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Pure refactor. Shorten code by using an AST builder method that creates the desired type directly,

This was referenced Jul 17, 2026
Merged
Merged
Merged
Merged
@overlookmotel Graphite App

overlookmotel commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 17, 2026
Merged
Merged
Merged
@github-actions github-actions Bot added the A-parser Area - Parser label Jul 17, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/07-17-refactor_parser_shorten_code_constructing_objectpropertykind_ (833e7bd) with main (2338c13)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (f78e096) during the generation of this report, so 2338c13 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel
overlookmotel force-pushed the om/07-17-refactor_parser_shorten_code_constructing_objectpropertykind_ branch from ccd88a6 to b8bf085 Compare July 17, 2026 13:08
@overlookmotel overlookmotel mentioned this pull request Jul 17, 2026
Merged
@overlookmotel
overlookmotel marked this pull request as ready for review July 17, 2026 13:23
Copilot AI review requested due to automatic review settings July 17, 2026 13:23
Copilot AI reviewed Jul 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the TypeScript parser’s import-type options parsing to construct ObjectPropertyKind directly via the AST builder helper, removing an intermediate ObjectProperty allocation/wrap step.

Changes:

  • Replaces manual ObjectProperty::boxed(...) + ObjectPropertyKind::ObjectProperty(...) wrapping with ObjectPropertyKind::new_object_property(...).
  • Simplifies the ObjectExpression::boxed(...) call to use the directly-produced ObjectPropertyKind.

@overlookmotel overlookmotel self-assigned this Jul 17, 2026
This was referenced Jul 17, 2026
Merged
Merged
@graphite-app

graphite-app Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
refactor(parser): shorten code constructing ObjectPropertyKind (#24626
833e7bd 
)

Pure refactor. Shorten code by using an AST builder method that creates the desired type directly,
@graphite-app
graphite-app Bot force-pushed the om/07-17-test_minifier_simplify_arenavec_builder_args_to_array branch from 3f24355 to f78e096 Compare July 17, 2026 13:53
@graphite-app
graphite-app Bot requested a review from Dunqing as a code owner July 17, 2026 13:53
@graphite-app
graphite-app Bot force-pushed the om/07-17-refactor_parser_shorten_code_constructing_objectpropertykind_ branch from b8bf085 to 833e7bd Compare July 17, 2026 13:53
Base automatically changed from om/07-17-test_minifier_simplify_arenavec_builder_args_to_array to main July 17, 2026 14:01
@graphite-app
graphite-app Bot merged commit 833e7bd into main Jul 17, 2026
42 checks passed
@graphite-app
graphite-app Bot deleted the om/07-17-refactor_parser_shorten_code_constructing_objectpropertykind_ branch July 17, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@camc314 camc314 camc314 approved these changes
@Dunqing Dunqing Awaiting requested review from Dunqing

Assignees

@overlookmotel overlookmotel

Labels

A-parser Area - Parser

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314