Skip to content

perf(formatter): stage assignment-like left hand side on the heap#24613

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap
Jul 22, 2026
Merged

perf(formatter): stage assignment-like left hand side on the heap#24613
graphite-app[bot] merged 1 commit into
mainfrom
07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap

Conversation

@leaysgur

@leaysgur leaysgur commented Jul 17, 2026

Copy link
Copy Markdown
Member

The last section where arena stranding was taking place.


There was a suggestion to use a dedicated temporary-arena as a temporary data storage; however, as with the previous JSX PR and this PR has become clear that this does not meet the current requirements.

leaysgur commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 5.24%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 55 untouched benchmarks
⏩ 19 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation formatter[types.ts] 12.5 ms 11.6 ms +7.36%
Simulation formatter[App.tsx] 47.4 ms 45.9 ms +3.16%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap (a1da8be) with main (8eb9eca)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 07-16-perf_formatter_accumulate_jsx_child-list_builders_on_the_heap (679a9e8) during the generation of this report, so main (8eb9eca) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@oxc-guard

oxc-guard Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Oxfmt Ecosystem CI

suite oxfmt@latest main refs/pull/24613/head branch
AmanVarshney01/create-better-t-stack
eggjs/egg
fastify/fastify-vite
cnpm/cnpmcore
npmx-dev/npmx.dev
vercel/turborepo
huggingface/huggingface.js
actualbudget/actual
fuma-nama/fumadocs
tale/headplane
dyad-sh/dyad
aidenybai/react-grab
mastodon/mastodon
cloudflare/workers-sdk
vuejs/core
openclaw/openclaw
formatjs/formatjs
rolldown/rolldown
cloudflare/agents
lichess-org/lila
getsentry/sentry-javascript
vuejs/pinia
Comfy-Org/ComfyUI_frontend ⚠️
monkeytypegame/monkeytype
mantinedev/mantine

💥 = panic, ⚠️ = error e.g. parse error (main/branch columns: only new errors), ❌ = diff or exit code mismatch, 🟨 = differs from oxfmt@latest (merged-but-unreleased changes)

@leaysgur
leaysgur force-pushed the 07-16-perf_formatter_accumulate_jsx_child-list_builders_on_the_heap branch from d9a6184 to 8510ba2 Compare July 21, 2026 06:11
@leaysgur
leaysgur force-pushed the 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap branch 2 times, most recently from 1045871 to a78f766 Compare July 21, 2026 07:55
@leaysgur
leaysgur force-pushed the 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap branch from a78f766 to 4488757 Compare July 21, 2026 09:26
@leaysgur
leaysgur force-pushed the 07-16-perf_formatter_accumulate_jsx_child-list_builders_on_the_heap branch 2 times, most recently from 0433b79 to 679a9e8 Compare July 22, 2026 05:04
@leaysgur
leaysgur force-pushed the 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap branch from 4488757 to a1da8be Compare July 22, 2026 05:04
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jul 22, 2026
@graphite-app

graphite-app Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Merge activity

…4613)

The last section where arena stranding was taking place.

---

There was a suggestion to use a dedicated temporary-arena as a temporary data storage; however, as with the previous JSX PR and this PR has become clear that this does not meet the current requirements.
@graphite-app
graphite-app Bot force-pushed the 07-16-perf_formatter_accumulate_jsx_child-list_builders_on_the_heap branch from 679a9e8 to 94de05f Compare July 22, 2026 06:33
@graphite-app
graphite-app Bot force-pushed the 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap branch from a1da8be to a5f7b15 Compare July 22, 2026 06:33
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 22, 2026
Base automatically changed from 07-16-perf_formatter_accumulate_jsx_child-list_builders_on_the_heap to main July 22, 2026 06:39
@graphite-app
graphite-app Bot merged commit a5f7b15 into main Jul 22, 2026
32 checks passed
@graphite-app
graphite-app Bot deleted the 07-17-perf_formatter_stage_assignment-like_left_hand_side_on_the_heap branch July 22, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant