Skip to content

fix(formatter_graphql): keep same line comments pending across intervening tokens#24579

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-15-fix_formatter_graphql_keep_same_line_comments_pending_across_intervening_tokens
Jul 16, 2026
Merged

fix(formatter_graphql): keep same line comments pending across intervening tokens#24579
graphite-app[bot] merged 1 commit into
mainfrom
07-15-fix_formatter_graphql_keep_same_line_comments_pending_across_intervening_tokens

Conversation

@leaysgur

@leaysgur leaysgur commented Jul 16, 2026

Copy link
Copy Markdown
Member

Ensure consistent behavior across all formatters.

Line comments at the EOL are not included in the calculation of print-width.

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the A-formatter Area - Formatter label Jul 16, 2026
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jul 16, 2026
@graphite-app

graphite-app Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Merge activity

…ening tokens (#24579)

Ensure consistent behavior across all formatters.

Line comments at the EOL are not included in the calculation of `print-width`.
@graphite-app
graphite-app Bot force-pushed the 07-15-fix_formatter_graphql_keep_same_line_comments_pending_across_intervening_tokens branch from 41c0e5f to 5f76998 Compare July 16, 2026 01:37
graphite-app Bot pushed a commit that referenced this pull request Jul 16, 2026
@graphite-app
graphite-app Bot merged commit 5f76998 into main Jul 16, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 16, 2026
@graphite-app
graphite-app Bot deleted the 07-15-fix_formatter_graphql_keep_same_line_comments_pending_across_intervening_tokens branch July 16, 2026 01:41
graphite-app Bot pushed a commit that referenced this pull request Jul 16, 2026
camc314 added a commit that referenced this pull request Jul 21, 2026
# Oxlint
### 💥 BREAKING CHANGES

- 54cc121 ast: [**BREAKING**] Split `MetaProperty` into `ImportMeta` and
`NewTarget` (#24557) (camc314)

### 🚀 Features

- 7b045cd minfier: Drop last break from last switch case (#24673)
(Armano)
- dd18383 linter/node: Implement no-top-level-await rule (#24634)
(Connor Shea)
- 16a65f2 linter/react: Implement function-component-definition rule
(#24471) (Cole Ellison)
- 7f1f585 linter: Reuse `jest/padding-around-test-blocks` for
`vitest/padding-around-test-blocks` (#24519) (Mikhail Baev)
- 99978a8 linter/import/consistent-type-specifier-style: Support
`prefer-top-level-if-only-type-imports` option (#24502) (camc314)

### 🐛 Bug Fixes

- 0184ad6 linter/unicorn/no-useless-undefined: Preserve valid parameter
defaults (#24686) (camc314)
- 8694167 linter/eslint/prefer-destructuring: Handle typed declarations
(#24616) (camc314)
- 477cf0f linter/eslint/no-throw-literal: Handle assigned errors
(#24561) (Cole Ellison)
- ac9200a linter: Detect React components from returned JSX (#24521)
(camc314)
- c0a6522 linter/eslint/no-useless-computed-key: Allow TS syntax in
computed keys (#24524) (Cole Ellison)

### ⚡ Performance

- 346eed1 linter/unicorn/prefer-event-target: Only run on `Class` and
`NewExpression` nodes (#24685) (Mikhail Baev)
- 7be5cf0 oxlint/lsp: Only invoke lint on code actions when document is
not opened (#24676) (Sysix)
- d3f07a0 diagnostics: Box OxcDiagnosticInner to reduce binary size
(#24665) (Boshen)
- 90ae040 linter/reporter/stylish: Compute diagnostic Info once per
diagnostic (#24525) (connorshea)

### 📚 Documentation

- e6f7174 linter/valid-expect: Fix correct example being identical to
incorrect one (#24468) (mkan0141)
# Oxfmt
### 💥 BREAKING CHANGES

- 54cc121 ast: [**BREAKING**] Split `MetaProperty` into `ImportMeta` and
`NewTarget` (#24557) (camc314)

### 🚀 Features

- 3d22307 parser: Add `ParseOptions::enable_ident_hashes` (#24491)
(Boshen)

### 🐛 Bug Fixes

- 6fe866a oxfmt: Keep tailwind classes glued to template expr with
`preserveWhitespace` (#24609) (leaysgur)
- 33e32d8 formatter_css: Use `line_suffix` for EOL line comment (#24580)
(leaysgur)
- 5f76998 formatter_graphql: Keep same line comments pending across
intervening tokens (#24579) (leaysgur)

Co-authored-by: Boshen <[email protected]>
Co-authored-by: Cameron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant