Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #2457 will improve performances by 4.52%Comparing Summary
Benchmarks breakdown
|
|
Does this mean we could use oxc_parser for eslint as well as prettier? |
|
Maybe... Just to say this is very early stage work, the concept is not proven, and there is a long way to go yet. Some significant things would need to change within OXC to convert this from an experiment to a solid, dependable reality. Personally, I do believe there is potential in this approach, but I think it's premature at this stage to talk a great deal about applications. Sorry if that sounds negative. I'm just trying to give a realistic answer. |
|
That's okay 😀 that's a perfectly reasonably answer |
2b18d0f to
862a1e8
Compare
780fba0 to
7e5843a
Compare
7e5843a to
1ab22a7
Compare
e890c29 to
7ce56e2
Compare
0ed60fb to
23c400d
Compare
|
I don't believe the Codspeed benchmarks are accurate. Running benchmarks locally, I'm seeing more like x3 - x5 speed-up. Will investigate. |
8189817 to
7554739
Compare
|
Yes, benchmarks on CodSpeed are completely wrong. Have raised an issue CodSpeedHQ/action#96 |
f1c4d84 to
ef6a6af
Compare
c367d50 to
851bc1c
Compare
|
Closing as I'm working on a new version. |

Very rough POC for #2409. Nowhere near ready to merge.
Mostly works. JS AST for
checker.tsvia "raw" transfer matches AST produced via current JSON API exactly.Some errors in AST forpdf.mjsandantd.jsdue to some of reasons listed below.Edit 8/3/24: Output for
pdf.mjsandantd.jsis now correct.Current deficiencies:
Incorrect output for files containing any non-ASCII characters.Does not handle strings/identifiers/regexps containing\escapes.Statementand a few other types increase in size by 8 bytes (likely the cause of the performance regression seen in benchmarks).Requires size of AST to be known in advance.Memory handling may be unsound!