Skip to content

feat(linter/import/consistent-type-specifier-style): support prefer-top-level-if-only-type-imports option#24502

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/consistent-type-specifier-style-only-type-imports
Jul 14, 2026
Merged

feat(linter/import/consistent-type-specifier-style): support prefer-top-level-if-only-type-imports option#24502
graphite-app[bot] merged 1 commit into
mainfrom
codex/consistent-type-specifier-style-only-type-imports

Conversation

@camc314

@camc314 camc314 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Re-port upstream support for prefer-top-level-if-only-type-imports.
  • Allow mixed value/type imports while requiring top-level syntax for imports containing only types.
  • Preserve Oxlint's existing default and declaration-file behavior.
  • Regenerate the JSON schema and TypeScript configuration types.

Reference

#1117 (comment)

Copilot AI review requested due to automatic review settings July 14, 2026 08:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI labels Jul 14, 2026
@camc314

camc314 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

cc @beeequeue

@camc314 camc314 changed the title feat(linter/import/consistent-type-specifier-style): support conditional top-level imports feat(linter/import/consistent-type-specifier-style): support prefer-top-level-if-only-type-imports option Jul 14, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing codex/consistent-type-specifier-style-only-type-imports (5e685c9) with main (3a36f2a)2

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (4de1624) during the generation of this report, so 3a36f2a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 self-assigned this Jul 14, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 14, 2026

camc314 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

…top-level-if-only-type-imports` option (#24502)

## Summary

- Re-port upstream support for prefer-top-level-if-only-type-imports.
- Allow mixed value/type imports while requiring top-level syntax for imports containing only types.
- Preserve Oxlint's existing default and declaration-file behavior.
- Regenerate the JSON schema and TypeScript configuration types.

## Reference

#1117 (comment)
@graphite-app
graphite-app Bot force-pushed the codex/consistent-type-specifier-style-only-type-imports branch from 5e685c9 to 99978a8 Compare July 14, 2026 09:25
@graphite-app
graphite-app Bot merged commit 99978a8 into main Jul 14, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 14, 2026
@graphite-app
graphite-app Bot deleted the codex/consistent-type-specifier-style-only-type-imports branch July 14, 2026 09:30
camc314 added a commit that referenced this pull request Jul 21, 2026
# Oxlint
### 💥 BREAKING CHANGES

- 54cc121 ast: [**BREAKING**] Split `MetaProperty` into `ImportMeta` and
`NewTarget` (#24557) (camc314)

### 🚀 Features

- 7b045cd minfier: Drop last break from last switch case (#24673)
(Armano)
- dd18383 linter/node: Implement no-top-level-await rule (#24634)
(Connor Shea)
- 16a65f2 linter/react: Implement function-component-definition rule
(#24471) (Cole Ellison)
- 7f1f585 linter: Reuse `jest/padding-around-test-blocks` for
`vitest/padding-around-test-blocks` (#24519) (Mikhail Baev)
- 99978a8 linter/import/consistent-type-specifier-style: Support
`prefer-top-level-if-only-type-imports` option (#24502) (camc314)

### 🐛 Bug Fixes

- 0184ad6 linter/unicorn/no-useless-undefined: Preserve valid parameter
defaults (#24686) (camc314)
- 8694167 linter/eslint/prefer-destructuring: Handle typed declarations
(#24616) (camc314)
- 477cf0f linter/eslint/no-throw-literal: Handle assigned errors
(#24561) (Cole Ellison)
- ac9200a linter: Detect React components from returned JSX (#24521)
(camc314)
- c0a6522 linter/eslint/no-useless-computed-key: Allow TS syntax in
computed keys (#24524) (Cole Ellison)

### ⚡ Performance

- 346eed1 linter/unicorn/prefer-event-target: Only run on `Class` and
`NewExpression` nodes (#24685) (Mikhail Baev)
- 7be5cf0 oxlint/lsp: Only invoke lint on code actions when document is
not opened (#24676) (Sysix)
- d3f07a0 diagnostics: Box OxcDiagnosticInner to reduce binary size
(#24665) (Boshen)
- 90ae040 linter/reporter/stylish: Compute diagnostic Info once per
diagnostic (#24525) (connorshea)

### 📚 Documentation

- e6f7174 linter/valid-expect: Fix correct example being identical to
incorrect one (#24468) (mkan0141)
# Oxfmt
### 💥 BREAKING CHANGES

- 54cc121 ast: [**BREAKING**] Split `MetaProperty` into `ImportMeta` and
`NewTarget` (#24557) (camc314)

### 🚀 Features

- 3d22307 parser: Add `ParseOptions::enable_ident_hashes` (#24491)
(Boshen)

### 🐛 Bug Fixes

- 6fe866a oxfmt: Keep tailwind classes glued to template expr with
`preserveWhitespace` (#24609) (leaysgur)
- 33e32d8 formatter_css: Use `line_suffix` for EOL line comment (#24580)
(leaysgur)
- 5f76998 formatter_graphql: Keep same line comments pending across
intervening tokens (#24579) (leaysgur)

Co-authored-by: Boshen <[email protected]>
Co-authored-by: Cameron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants