Skip to content

refactor(formatter): unify type cast binding classification into TypeCast enum#24445

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-13-refactor_formatter_unify_type_cast_binding_classification
Jul 13, 2026
Merged

refactor(formatter): unify type cast binding classification into TypeCast enum#24445
graphite-app[bot] merged 1 commit into
mainfrom
07-13-refactor_formatter_unify_type_cast_binding_classification

Conversation

@leaysgur

@leaysgur leaysgur commented Jul 13, 2026

Copy link
Copy Markdown
Member

Use TypeCast enum for SoT to handle JSDoc type-cast and parens printing.

leaysgur commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Jul 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1


Comparing 07-13-refactor_formatter_unify_type_cast_binding_classification (cb8b75d) with 07-13-fix_formatter_do_not_add_extra_parens_with_type_cast_comment (d7c12b5)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur changed the title refactor(formatter): unify type cast binding classification into typecast enum refactor(formatter): unify type cast binding classification into TypeCast enum Jul 13, 2026
@leaysgur
leaysgur force-pushed the 07-13-refactor_formatter_unify_type_cast_binding_classification branch from fbfdc83 to cb8b75d Compare July 13, 2026 07:05
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
@graphite-app

graphite-app Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app
graphite-app Bot force-pushed the 07-13-fix_formatter_do_not_add_extra_parens_with_type_cast_comment branch from d7c12b5 to 25306e9 Compare July 13, 2026 07:44
@graphite-app
graphite-app Bot requested a review from overlookmotel as a code owner July 13, 2026 07:44
graphite-app Bot pushed a commit that referenced this pull request Jul 13, 2026
…eCast` enum (#24445)

Use `TypeCast` enum for SoT to handle JSDoc type-cast and parens printing.
@graphite-app
graphite-app Bot force-pushed the 07-13-refactor_formatter_unify_type_cast_binding_classification branch from cb8b75d to ea923bb Compare July 13, 2026 07:44
Base automatically changed from 07-13-fix_formatter_do_not_add_extra_parens_with_type_cast_comment to main July 13, 2026 07:48
…eCast` enum (#24445)

Use `TypeCast` enum for SoT to handle JSDoc type-cast and parens printing.
@graphite-app
graphite-app Bot force-pushed the 07-13-refactor_formatter_unify_type_cast_binding_classification branch from ea923bb to cfed680 Compare July 13, 2026 07:49
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
@graphite-app
graphite-app Bot merged commit cfed680 into main Jul 13, 2026
29 checks passed
@graphite-app
graphite-app Bot deleted the 07-13-refactor_formatter_unify_type_cast_binding_classification branch July 13, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant