docs(ast_tools): correct comments concerning enum inheritance#24395
Merged
graphite-app[bot] merged 1 commit intoJul 12, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation comments in the AST tools derive generators to reflect the current enum-variant inheritance mechanism (INHERIT marker variants) after removal of the older inherit_variants! macro, keeping the rationale for delegation clear and up to date.
Changes:
- Refresh and shorten comments in the
estreederive generator describing delegation for inherited variants. - Refresh and reformat comments in the
clone_inderive generator describing delegation viato_*casts andFromimpls. - Minor whitespace tweaks around inherited-variant arm generation blocks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tasks/ast_tools/src/derives/estree.rs | Updates comments explaining how INHERIT-based inherited variants delegate ESTree serialization to reduce duplicated match arms/binary size. |
| tasks/ast_tools/src/derives/clone_in.rs | Updates comments explaining how INHERIT-based inherited variants delegate cloning via to_* + From to avoid duplicated match arms/binary bloat. |
Contributor
Merge activity
|
Follow-on after #23555. Since that PR was written, the `inherit_variants!` macro was removed, so some of the comments were out of date. Bring those comments up to date. Also shorten the comments a bit and reformat them.
graphite-app
Bot
force-pushed
the
om/07-12-docs_ast_tools_correct_comments_concerning_enum_inheritance
branch
from
July 12, 2026 10:25
e049e5c to
c15c423
Compare
graphite-app
Bot
deleted the
om/07-12-docs_ast_tools_correct_comments_concerning_enum_inheritance
branch
July 12, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #23555.
Since that PR was written, the
inherit_variants!macro was removed, so some of the comments were out of date.Bring those comments up to date. Also shorten the comments a bit and reformat them.