fix(semantic): respect implicit arguments bindings#24392
Draft
Minghan2005 wants to merge 1 commit into
Draft
Conversation
Minghan2005
force-pushed
the
codex/fix-arguments-shadow-resolution
branch
from
July 14, 2026 17:32
b60463f to
394b0d6
Compare
Author
|
I’ve rebased this branch onto the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argumentsreferences from walking past a non-arrow function's implicit arguments bindingRoot cause
Oxc intentionally represents the implicit arguments object as an unresolved reference instead of creating a synthetic symbol. The walk-up resolver did not treat non-arrow function scopes as a boundary, so it could incorrectly attach an inner
argumentsreference to an outer declaration with the same name.Validation
env -u NO_COLOR just readycargo test -p oxc_semantic --all-featurescargo clippy -p oxc_semantic --all-targets --all-features -- -D warningsprefer-rest-params,no-undef, andobject-shorthandCloses #23844.
AI assistance
This change was developed with assistance from OpenAI Codex. The implementation and regression coverage were validated with the repository's full prescribed
just readyworkflow.