Skip to content

refactor(formatter): simplify property key and string literal formatting#24321

Merged
graphite-app[bot] merged 1 commit into
mainfrom
07-09-refactor_formatter_simplify_property_key_and_string_literal_formatting
Jul 9, 2026
Merged

refactor(formatter): simplify property key and string literal formatting#24321
graphite-app[bot] merged 1 commit into
mainfrom
07-09-refactor_formatter_simplify_property_key_and_string_literal_formatting

Conversation

@leaysgur

@leaysgur leaysgur commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Reuse format_property_key() everywhere.

@github-actions github-actions Bot added the A-formatter Area - Formatter label Jul 9, 2026
This was referenced Jul 9, 2026
Merged
Merged
Merged
Merged
@leaysgur Graphite App

leaysgur commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 9, 2026
Merged
Merged
@codspeed-hq

codspeed-hq Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing 07-09-refactor_formatter_simplify_property_key_and_string_literal_formatting (f662532) with main (b7c7e15)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@leaysgur
leaysgur requested a review from overlookmotel as a code owner July 9, 2026 08:07
@leaysgur
leaysgur force-pushed the 07-09-refactor_formatter_simplify_property_key_and_string_literal_formatting branch 2 times, most recently from f048781 to 1c5abc4 Compare July 9, 2026 08:31
@leaysgur
leaysgur force-pushed the 07-09-fix_formatter_add_parens_for_import_and_private_field_in_new_callee_chain branch from f58c6d2 to 2e8f65e Compare July 9, 2026 08:31
@oxc-guard

oxc-guard Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Oxfmt Ecosystem CI

suite oxfmt@latest main refs/pull/24321/head branch
formatjs/formatjs ❌ ✅ ✅
AmanVarshney01/create-better-t-stack ✅ ✅ ✅
fuma-nama/fumadocs ❌ ✅ ✅
cnpm/cnpmcore ❌ ✅ ✅
vercel/turborepo ✅ ✅ ✅
monkeytypegame/monkeytype ❌ ✅ ✅
actualbudget/actual ❌ 🟨 ✅
eggjs/egg ❌ ✅ ✅
fastify/fastify-vite ❌ ✅ ✅
vuejs/pinia ❌ ✅ ✅
dyad-sh/dyad ❌ ✅ ✅
Comfy-Org/ComfyUI_frontend ⚠️ 🟨 ❌
mantinedev/mantine ❌ ✅ ✅
tale/headplane ❌ ✅ ✅
getsentry/sentry-javascript ❌ 🟨 ✅
cloudflare/workers-sdk ❌ 🟨 ❌
rolldown/rolldown ❌ ✅ ✅
openclaw/openclaw ❌ ✅ ❌
mastodon/mastodon ✅ ✅ ✅
lichess-org/lila ❌ ✅ ✅
vuejs/core ✅ 🟨 ✅
huggingface/huggingface.js ❌ 🟨 ✅
aidenybai/react-grab ✅ ✅ ✅
npmx-dev/npmx.dev ❌ ✅ ✅
cloudflare/agents ❌ ✅ ❌

💥 = panic, ⚠️ = error e.g. parse error (main/branch columns: only new errors), ❌ = diff or exit code mismatch, 🟨 = differs from oxfmt@latest (merged-but-unreleased changes)

@leaysgur

leaysgur commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

NOTE: All diffs are unrelated to recent PRs.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jul 9, 2026
@leaysgur Graphite App

leaysgur commented Jul 9, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member Author

Merge activity

@graphite-app
graphite-app Bot force-pushed the 07-09-fix_formatter_add_parens_for_import_and_private_field_in_new_callee_chain branch from 2e8f65e to 27577c5 Compare July 9, 2026 09:11
@graphite-app
graphite-app Bot force-pushed the 07-09-refactor_formatter_simplify_property_key_and_string_literal_formatting branch from 1c5abc4 to 901567c Compare July 9, 2026 09:11
@graphite-app
graphite-app Bot changed the base branch from 07-09-fix_formatter_add_parens_for_import_and_private_field_in_new_callee_chain to graphite-base/24321 July 9, 2026 09:17
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 9, 2026
@graphite-app
graphite-app Bot changed the base branch from graphite-base/24321 to main July 9, 2026 09:24
@leaysgur
refactor(formatter): simplify property key and string literal formatt…
f662532 
…ing (#24321)

Reuse `format_property_key()` everywhere.
@graphite-app
graphite-app Bot force-pushed the 07-09-refactor_formatter_simplify_property_key_and_string_literal_formatting branch from 901567c to f662532 Compare July 9, 2026 09:24
@graphite-app
graphite-app Bot merged commit f662532 into main Jul 9, 2026
36 checks passed
@graphite-app
graphite-app Bot deleted the 07-09-refactor_formatter_simplify_property_key_and_string_literal_formatting branch July 9, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur