fix(isolated-declarations): emit const readonly fields as types#24288
Merged
graphite-app[bot] merged 1 commit intoJul 8, 2026
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
camc314
commented
Jul 8, 2026
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes isolated-declarations .d.ts emit to match TypeScript behavior for readonly class fields initialized with as const, ensuring const assertions produce type form (: "a") rather than value form (= "a") and preventing unwanted widening under downstream inference.
Changes:
- Adjust readonly class-property emission to preserve value initializers only for non-
as constliteral initializers, letting const assertions flow through const-expression-to-type conversion. - Update existing readonly-literal initializer snapshot expectations for
as constcases. - Add a new regression fixture + snapshot for #24284 covering instance/static readonly and const-asserted initializers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_isolated_declarations/src/class.rs | Stops unwrapping as const in readonly initializer preservation; only keeps non-const-asserted literal initializers as values. |
| crates/oxc_isolated_declarations/tests/snapshots/readonly-class-property-initializer.snap | Updates expected .d.ts output so readonly as const literals emit as type annotations. |
| crates/oxc_isolated_declarations/tests/fixtures/issue-24284.ts | Adds a targeted fixture reproducing the reported divergence (#24284). |
| crates/oxc_isolated_declarations/tests/snapshots/issue-24284.snap | Adds a regression snapshot asserting correct .d.ts output for the new fixture. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
Author
Merge activity
|
## Summary Fixes #24284. TypeScript 6.0.3 emits bare readonly literal class fields as value initializers, but emits readonly `as const` literal fields as type annotations. Oxc previously unwrapped `as const` in the readonly class-property initializer path, so `static readonly A = "a" as const` became `static readonly A = "a";` instead of `static readonly A: "a";`. This changes the readonly class-property handling to preserve value initializers only for bare literals. Const assertions now flow through the existing const-expression type conversion.
graphite-app
Bot
force-pushed
the
agent/isolated-declarations-static-readonly-as-const
branch
from
July 8, 2026 10:55
9413c84 to
f17514b
Compare
graphite-app
Bot
deleted the
agent/isolated-declarations-static-readonly-as-const
branch
July 8, 2026 10:59
Boshen
added a commit
that referenced
this pull request
Jul 14, 2026
### 🚀 Features - 616bfa2 minifier: Remove unreachable code after terminating statements (#24441) (Dunqing) - ddab89a data_structures: Add `likely` and `unlikely` functions (#24368) (overlookmotel) - a3a39f9 react_compiler: Implement enableEmitHookGuards codegen (#24329) (Boshen) - b79eef7 minifier: Apply De Morgan's law to negated comparison chains in jump guards and loop tests (#24279) (Dunqing) - 34ff7b4 minifier: Drop write-only property assignments to unused local bindings by default (#24112) (Dunqing) - 1b829d8 semantic: Record const enums in EnumData (#24268) (Dunqing) - ba0944c semantic: Add `Scoping::set_symbol_span` (#24221) (camc314) ### 🐛 Bug Fixes - 7d33363 minifier: Preserve guaranteed throws from class heritage evaluation (#24349) (Dunqing) - 058a62f semantic: Track ambient contexts in `SemanticBuilder` (#24327) (camc314) - 721eb0b transformer/decorator: Scope accessor class binding (#24330) (camc314) - 1ebdce3 semantic: Allow reserved keywords in ambient declaration types (#24325) (camc314) - 460176a track-memory-allocations: Exclude arena chunks from Sys allocs (#24292) (Dunqing) - af4922b transformer: Clear lowered namespace redeclarations (#24300) (camc314) - ffd2765 semantic: Mark declared computed `MethodDefinition`s as type references (#24296) (camc314) - f17514b isolated-declarations: Emit const readonly fields as types (#24288) (camc314) - 40f769d minifier: Make `__proto__` write tracking execution-order independent (#24280) (Dunqing) - 6371fed transformer: Remove stale enum member bindings (#24272) (camc314) - f05dfab transformer: Correct symbol flags for lowered namespaces (#24271) (Dunqing) - 84eeb55 transformer: Correct symbol flags for lowered enums (#24269) (Dunqing) - c3057da transformer: Preserve generated class binding spans (#24220) (camc314) - 8260096 transformer: Correct span for lowered namespace symbol (#24222) (camc314) - 42d00d3 semantic: Mark declared class heritage as type references (#24237) (camc314) - 588d997 semantic: Mark TS `PropertyDefinition`s computed fields as type references (#24233) (camc314) - 9b95632 semantic: Mark computed method keys in `TSMethodSignature`s as type references (#24232) (camc314) ### ⚡ Performance - 5b26643 transformer_plugins: Dispatch global defines by trailing name (#23666) (Boshen) - dce0f29 react_compiler: Replace all compiled functions in a single AST walk (#24403) (Boshen) - f85f0d8 ast: Delegate inherited enum variants in clone_in and estree derives (#23555) (Boshen) - 3ff0234 allocator: Remove `unwrap` from `ReplaceWith` (#24365) (overlookmotel) - ab22e80 transformer: Fix Rust 1.97 performance regression (#24354) (camc314) - b47585c parser: Use `ReplaceWith` instead of `TakeIn` (#24018) (overlookmotel) - b227a06 minifier: Use `ReplaceWith` instead of `TakeIn` (#24017) (overlookmotel) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #24284.
TypeScript 6.0.3 emits bare readonly literal class fields as value initializers, but emits readonly
as constliteral fields as type annotations. Oxc previously unwrappedas constin the readonly class-property initializer path, sostatic readonly A = "a" as constbecamestatic readonly A = "a";instead ofstatic readonly A: "a";.This changes the readonly class-property handling to preserve value initializers only for bare literals. Const assertions now flow through the existing const-expression type conversion.