fix(semantic): mark computed method keys in TSMethodSignatures as type references#24232
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates oxc_semantic to treat computed TypeScript method/getter/setter keys as type-context references (via ValueAsType), aligning their resolution behavior with computed property signatures and type queries. It also refreshes conformance/snapshot outputs and adds regression fixtures.
Changes:
- Update the semantic builder to visit computed
TSMethodSignaturekeys usingReferenceFlags::ValueAsType. - Add a regression fixture + snapshot asserting computed method signature keys are marked as type references.
- Update Babel and TypeScript semantic coverage snapshots to reflect improved pass counts and resolved reference differences.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tasks/coverage/snapshots/semantic_typescript.snap | Updates TypeScript semantic conformance snapshot after reference-resolution changes. |
| tasks/coverage/snapshots/semantic_babel.snap | Updates Babel semantic conformance snapshot after reference-resolution changes. |
| crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method-computed-name2.snap | Updates expected reference flags from Read to Type for computed method key resolution. |
| crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method-computed-name.snap | Updates expected reference flags from Read to Type for computed method key resolution. |
| crates/oxc_semantic/tests/fixtures/oxc/ts/interfaces/computed-method-signatures.ts | Adds a regression fixture covering computed getter/setter and type-only imported computed method keys. |
| crates/oxc_semantic/tests/fixtures/oxc/ts/interfaces/computed-method-signatures.snap | Adds expected semantic snapshot for the new regression fixture. |
| crates/oxc_semantic/src/builder.rs | Adds custom visit_ts_method_signature handling to mark computed keys as ValueAsType. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
camc314
changed the title
TSMethodSignatures as type references
camc314
force-pushed
the
codex/fix-computed-method-reference-flags
branch
2 times, most recently
from
July 6, 2026 16:04
8f11e1a to
0a1d6ec
Compare
Contributor
Author
Merge activity
|
…ype references (#24232) ## Summary - resolve computed TypeScript method, getter, and setter keys through ValueAsType so their final references are Type - allow those keys to resolve value bindings and type-only import bindings consistently with computed property signatures and type queries - add regression coverage and update semantic conformance snapshots, yielding one additional Babel pass and six additional TypeScript passes Handled for TSPropertySignature via d8b9909
graphite-app
Bot
force-pushed
the
codex/fix-computed-method-reference-flags
branch
from
July 6, 2026 16:10
0a1d6ec to
9b95632
Compare
Boshen
added a commit
that referenced
this pull request
Jul 14, 2026
### 🚀 Features - 616bfa2 minifier: Remove unreachable code after terminating statements (#24441) (Dunqing) - ddab89a data_structures: Add `likely` and `unlikely` functions (#24368) (overlookmotel) - a3a39f9 react_compiler: Implement enableEmitHookGuards codegen (#24329) (Boshen) - b79eef7 minifier: Apply De Morgan's law to negated comparison chains in jump guards and loop tests (#24279) (Dunqing) - 34ff7b4 minifier: Drop write-only property assignments to unused local bindings by default (#24112) (Dunqing) - 1b829d8 semantic: Record const enums in EnumData (#24268) (Dunqing) - ba0944c semantic: Add `Scoping::set_symbol_span` (#24221) (camc314) ### 🐛 Bug Fixes - 7d33363 minifier: Preserve guaranteed throws from class heritage evaluation (#24349) (Dunqing) - 058a62f semantic: Track ambient contexts in `SemanticBuilder` (#24327) (camc314) - 721eb0b transformer/decorator: Scope accessor class binding (#24330) (camc314) - 1ebdce3 semantic: Allow reserved keywords in ambient declaration types (#24325) (camc314) - 460176a track-memory-allocations: Exclude arena chunks from Sys allocs (#24292) (Dunqing) - af4922b transformer: Clear lowered namespace redeclarations (#24300) (camc314) - ffd2765 semantic: Mark declared computed `MethodDefinition`s as type references (#24296) (camc314) - f17514b isolated-declarations: Emit const readonly fields as types (#24288) (camc314) - 40f769d minifier: Make `__proto__` write tracking execution-order independent (#24280) (Dunqing) - 6371fed transformer: Remove stale enum member bindings (#24272) (camc314) - f05dfab transformer: Correct symbol flags for lowered namespaces (#24271) (Dunqing) - 84eeb55 transformer: Correct symbol flags for lowered enums (#24269) (Dunqing) - c3057da transformer: Preserve generated class binding spans (#24220) (camc314) - 8260096 transformer: Correct span for lowered namespace symbol (#24222) (camc314) - 42d00d3 semantic: Mark declared class heritage as type references (#24237) (camc314) - 588d997 semantic: Mark TS `PropertyDefinition`s computed fields as type references (#24233) (camc314) - 9b95632 semantic: Mark computed method keys in `TSMethodSignature`s as type references (#24232) (camc314) ### ⚡ Performance - 5b26643 transformer_plugins: Dispatch global defines by trailing name (#23666) (Boshen) - dce0f29 react_compiler: Replace all compiled functions in a single AST walk (#24403) (Boshen) - f85f0d8 ast: Delegate inherited enum variants in clone_in and estree derives (#23555) (Boshen) - 3ff0234 allocator: Remove `unwrap` from `ReplaceWith` (#24365) (overlookmotel) - ab22e80 transformer: Fix Rust 1.97 performance regression (#24354) (camc314) - b47585c parser: Use `ReplaceWith` instead of `TakeIn` (#24018) (overlookmotel) - b227a06 minifier: Use `ReplaceWith` instead of `TakeIn` (#24017) (overlookmotel) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handled for TSPropertySignature via d8b9909