fix(transformer): correct span for lowered namespace symbol by camc314 · Pull Request #24222 · oxc-project/oxc

camc314 · 2026-07-06T12:26:55Z

Summary

preserve source spans when TypeScript namespace declarations are lowered to variable bindings
update semantic coverage snapshots, removing stale Span { start: 0, end: 0 } mismatches

Copilot

Pull request overview

Fixes incorrect (dummy 0..0) symbol spans produced when lowering TypeScript namespaces in the transformer, bringing rebuilt semantic symbol spans in line with the original identifier spans and removing related conformance snapshot mismatches.

Changes:

Assign the namespace binding’s real identifier span to the generated let <Name>; binding pattern and the symbol table entry.
Thread a binding_span through namespace variable declaration creation to avoid emitting dummy-span bindings.
Update transform/semantic conformance snapshots to reflect the corrected span behavior.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File	Description
crates/oxc_transformer/src/typescript/namespace.rs	Uses the namespace identifier span for the generated binding pattern and updates the symbol span to avoid `0..0` spans after lowering.
tasks/transform_conformance/snapshots/oxc.snap.md	Removes span mismatch entries now fixed by the transformer change.
tasks/transform_conformance/snapshots/babel.snap.md	Removes span mismatch entries now fixed by the transformer change.
tasks/coverage/snapshots/semantic_babel.snap	Removes span mismatch entries now fixed by the transformer change.

camc314 · 2026-07-06T12:29:13Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-07-06T12:30:49Z

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks¹

_{Comparing c/namespace-transformed-sym-span (501c38d) with c/set-symbol-span (69cb8c9)²}

19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on c/set-symbol-span (e42f9b6) during the generation of this report, so fcc12a1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2026-07-06T13:23:47Z

Merge activity

Jul 6, 1:23 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jul 6, 1:27 PM UTC: The Graphite merge queue removed this pull request due to removal of a downstack PR #24221.
Jul 6, 1:27 PM UTC: camc314 removed this pull request from the Graphite merge queue.
Jul 7, 2:26 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 7, 2:26 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Jul 7, 2:33 AM UTC: Merged by the Graphite merge queue.

## Summary - adds a new method on semantic's `Scoping` allowing setting the span of a symbol - this will be used in #24222

## Summary - preserve source spans when TypeScript namespace declarations are lowered to variable bindings - update semantic coverage snapshots, removing stale `Span { start: 0, end: 0 }` mismatches

## Summary - adds a new method on semantic's `Scoping` allowing setting the span of a symbol - this will be used in #24222

### 🚀 Features - 616bfa2 minifier: Remove unreachable code after terminating statements (#24441) (Dunqing) - ddab89a data_structures: Add `likely` and `unlikely` functions (#24368) (overlookmotel) - a3a39f9 react_compiler: Implement enableEmitHookGuards codegen (#24329) (Boshen) - b79eef7 minifier: Apply De Morgan's law to negated comparison chains in jump guards and loop tests (#24279) (Dunqing) - 34ff7b4 minifier: Drop write-only property assignments to unused local bindings by default (#24112) (Dunqing) - 1b829d8 semantic: Record const enums in EnumData (#24268) (Dunqing) - ba0944c semantic: Add `Scoping::set_symbol_span` (#24221) (camc314) ### 🐛 Bug Fixes - 7d33363 minifier: Preserve guaranteed throws from class heritage evaluation (#24349) (Dunqing) - 058a62f semantic: Track ambient contexts in `SemanticBuilder` (#24327) (camc314) - 721eb0b transformer/decorator: Scope accessor class binding (#24330) (camc314) - 1ebdce3 semantic: Allow reserved keywords in ambient declaration types (#24325) (camc314) - 460176a track-memory-allocations: Exclude arena chunks from Sys allocs (#24292) (Dunqing) - af4922b transformer: Clear lowered namespace redeclarations (#24300) (camc314) - ffd2765 semantic: Mark declared computed `MethodDefinition`s as type references (#24296) (camc314) - f17514b isolated-declarations: Emit const readonly fields as types (#24288) (camc314) - 40f769d minifier: Make `__proto__` write tracking execution-order independent (#24280) (Dunqing) - 6371fed transformer: Remove stale enum member bindings (#24272) (camc314) - f05dfab transformer: Correct symbol flags for lowered namespaces (#24271) (Dunqing) - 84eeb55 transformer: Correct symbol flags for lowered enums (#24269) (Dunqing) - c3057da transformer: Preserve generated class binding spans (#24220) (camc314) - 8260096 transformer: Correct span for lowered namespace symbol (#24222) (camc314) - 42d00d3 semantic: Mark declared class heritage as type references (#24237) (camc314) - 588d997 semantic: Mark TS `PropertyDefinition`s computed fields as type references (#24233) (camc314) - 9b95632 semantic: Mark computed method keys in `TSMethodSignature`s as type references (#24232) (camc314) ### ⚡ Performance - 5b26643 transformer_plugins: Dispatch global defines by trailing name (#23666) (Boshen) - dce0f29 react_compiler: Replace all compiled functions in a single AST walk (#24403) (Boshen) - f85f0d8 ast: Delegate inherited enum variants in clone_in and estree derives (#23555) (Boshen) - 3ff0234 allocator: Remove `unwrap` from `ReplaceWith` (#24365) (overlookmotel) - ab22e80 transformer: Fix Rust 1.97 performance regression (#24354) (camc314) - b47585c parser: Use `ReplaceWith` instead of `TakeIn` (#24018) (overlookmotel) - b227a06 minifier: Use `ReplaceWith` instead of `TakeIn` (#24017) (overlookmotel) Co-authored-by: Boshen <[email protected]>

camc314 requested a review from Dunqing as a code owner July 6, 2026 12:26

Copilot AI review requested due to automatic review settings July 6, 2026 12:26

github-actions Bot added the A-transformer Area - Transformer / Transpiler label Jul 6, 2026

Copilot started reviewing on behalf of camc314 July 6, 2026 12:27 View session

camc314 mentioned this pull request Jul 6, 2026

feat(semantic): add Scoping::set_symbol_span #24221

Merged

Copilot AI reviewed Jul 6, 2026

View reviewed changes

camc314 force-pushed the c/namespace-transformed-sym-span branch from 67f696c to a196867 Compare July 6, 2026 12:30

camc314 force-pushed the c/set-symbol-span branch from e5e8ad2 to 69cb8c9 Compare July 6, 2026 12:30

camc314 mentioned this pull request Jul 6, 2026

fix(transformer): preserve generated class binding spans #24220

Merged

camc314 assigned Dunqing Jul 6, 2026

camc314 force-pushed the c/set-symbol-span branch from 69cb8c9 to e42f9b6 Compare July 6, 2026 12:52

camc314 force-pushed the c/namespace-transformed-sym-span branch from a196867 to 501c38d Compare July 6, 2026 12:52

This was referenced Jul 6, 2026

fix(transformer): correct symbol flags for lowered namespaces #24224

Closed

fix(transformer): correct scoping flags for lowered enums #24225

Merged

fix(transformer): correct symbol flags for lowered enums #24226

Closed

camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 6, 2026 — with Graphite App

graphite-app Bot pushed a commit that referenced this pull request Jul 6, 2026

feat(semantic): add Scoping::set_symbol_span (#24221)

b86349c

## Summary - adds a new method on semantic's `Scoping` allowing setting the span of a symbol - this will be used in #24222

graphite-app Bot force-pushed the c/set-symbol-span branch from e42f9b6 to b86349c Compare July 6, 2026 13:24

graphite-app Bot force-pushed the c/namespace-transformed-sym-span branch from 501c38d to d3be3ad Compare July 6, 2026 13:24

camc314 marked this pull request as draft July 6, 2026 13:25

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 6, 2026

camc314 marked this pull request as ready for review July 6, 2026 18:33

Dunqing approved these changes Jul 7, 2026

View reviewed changes

Dunqing added the 0-merge Merge with Graphite Merge Queue label Jul 7, 2026

fix(transformer): correct span for lowered namespace symbol (#24222)

8260096

## Summary - preserve source spans when TypeScript namespace declarations are lowered to variable bindings - update semantic coverage snapshots, removing stale `Span { start: 0, end: 0 }` mismatches

graphite-app Bot pushed a commit that referenced this pull request Jul 7, 2026

feat(semantic): add Scoping::set_symbol_span (#24221)

ba0944c

## Summary - adds a new method on semantic's `Scoping` allowing setting the span of a symbol - this will be used in #24222

graphite-app Bot force-pushed the c/set-symbol-span branch from b86349c to ba0944c Compare July 7, 2026 02:27

graphite-app Bot force-pushed the c/namespace-transformed-sym-span branch from d3be3ad to 8260096 Compare July 7, 2026 02:27

Base automatically changed from c/set-symbol-span to main July 7, 2026 02:31

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 7, 2026

graphite-app Bot merged commit 8260096 into main Jul 7, 2026
31 checks passed

graphite-app Bot deleted the c/namespace-transformed-sym-span branch July 7, 2026 02:33

oxc-guard Bot mentioned this pull request Jul 13, 2026

release(crates): oxc v0.140.0 #24453

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(transformer): correct span for lowered namespace symbol#24222

fix(transformer): correct span for lowered namespace symbol#24222
graphite-app[bot] merged 1 commit into
mainfrom
c/namespace-transformed-sym-span

camc314 commented Jul 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 commented Jul 6, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

graphite-app Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

camc314 commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

camc314 commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

graphite-app Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Jul 6, 2026 •

edited

Loading

camc314 commented Jul 6, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 6, 2026 •

edited

Loading

graphite-app Bot commented Jul 6, 2026 •

edited

Loading