fix(transformer): preserve generated class binding spans#24220
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves semantic span fidelity for bindings created during transformations, so transformed (lowered) constructs retain source-like spans and stop producing Span { start: 0, end: 0 } mismatches in semantic coverage snapshots.
Changes:
- Add span-aware binding creation APIs to
oxc_traverse(generate_spanned_binding/add_spanned_binding). - Use symbol-backed spans when generating binding patterns for TypeScript namespace lowering and legacy decorator class lowering.
- Update semantic coverage snapshots to reflect the removed zero-span mismatches and improved pass counts.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/coverage/snapshots/semantic_test262.snap | Updates semantic snapshot after span-preservation fixes (+8 passing noted in PR). |
| tasks/coverage/snapshots/semantic_misc.snap | Updates misc semantic snapshot after removing stale zero-span mismatches. |
| tasks/coverage/snapshots/semantic_babel.snap | Updates Babel semantic snapshot reflecting span mismatch removals (+1 passing noted in PR). |
| crates/oxc_traverse/src/context/scoping.rs | Introduces add_spanned_binding / generate_spanned_binding to create symbols/bindings with non-dummy spans. |
| crates/oxc_traverse/src/context/mod.rs | Exposes TraverseCtx::generate_spanned_binding as a convenience wrapper. |
| crates/oxc_transformer/src/typescript/namespace.rs | Uses symbol_span to generate a span-correct binding pattern for lowered namespace bindings. |
| crates/oxc_transformer/src/decorator/legacy/mod.rs | Preserves class binding spans by generating spanned bindings/patterns during legacy decorator lowering. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 412066df1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
camc314
force-pushed
the
codex/preserve-transformed-binding-spans
branch
from
July 6, 2026 12:16
412066d to
39a65fb
Compare
camc314
marked this pull request as draft
July 6, 2026 12:27
camc314
changed the title
camc314
force-pushed
the
graphite-base/24220
branch
from
July 6, 2026 12:36
3ae8317 to
a196867
Compare
camc314
force-pushed
the
codex/preserve-transformed-binding-spans
branch
from
July 6, 2026 12:36
39a65fb to
783dae8
Compare
camc314
changed the base branch from
graphite-base/24220
to
c/namespace-transformed-sym-span
July 6, 2026 12:36
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 6, 2026
camc314
marked this pull request as ready for review
July 6, 2026 12:37
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 783dae8f0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
camc314
force-pushed
the
codex/preserve-transformed-binding-spans
branch
2 times, most recently
from
July 6, 2026 12:52
0f0ea8d to
b59430b
Compare
camc314
force-pushed
the
c/namespace-transformed-sym-span
branch
from
July 6, 2026 12:52
a196867 to
501c38d
Compare
This was referenced Jul 6, 2026
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
c/namespace-transformed-sym-span
branch
from
July 6, 2026 13:24
501c38d to
d3be3ad
Compare
github-actions
Bot
added
A-ast
camc314
force-pushed
the
codex/preserve-transformed-binding-spans
branch
from
July 7, 2026 06:37
9378b8f to
5553efa
Compare
camc314
added
0-merge
## Summary
- preserve outer and inner class binding spans during legacy decorator lowering
- add a span-aware traversal binding generator for transformed source-backed bindings
- update semantic coverage snapshots, removing stale `Span { start: 0, end: 0 }` mismatches
graphite-app
Bot
force-pushed
the
codex/preserve-transformed-binding-spans
branch
from
July 7, 2026 06:53
5553efa to
c3057da
Compare
Boshen
added a commit
that referenced
this pull request
Jul 14, 2026
### 🚀 Features - 616bfa2 minifier: Remove unreachable code after terminating statements (#24441) (Dunqing) - ddab89a data_structures: Add `likely` and `unlikely` functions (#24368) (overlookmotel) - a3a39f9 react_compiler: Implement enableEmitHookGuards codegen (#24329) (Boshen) - b79eef7 minifier: Apply De Morgan's law to negated comparison chains in jump guards and loop tests (#24279) (Dunqing) - 34ff7b4 minifier: Drop write-only property assignments to unused local bindings by default (#24112) (Dunqing) - 1b829d8 semantic: Record const enums in EnumData (#24268) (Dunqing) - ba0944c semantic: Add `Scoping::set_symbol_span` (#24221) (camc314) ### 🐛 Bug Fixes - 7d33363 minifier: Preserve guaranteed throws from class heritage evaluation (#24349) (Dunqing) - 058a62f semantic: Track ambient contexts in `SemanticBuilder` (#24327) (camc314) - 721eb0b transformer/decorator: Scope accessor class binding (#24330) (camc314) - 1ebdce3 semantic: Allow reserved keywords in ambient declaration types (#24325) (camc314) - 460176a track-memory-allocations: Exclude arena chunks from Sys allocs (#24292) (Dunqing) - af4922b transformer: Clear lowered namespace redeclarations (#24300) (camc314) - ffd2765 semantic: Mark declared computed `MethodDefinition`s as type references (#24296) (camc314) - f17514b isolated-declarations: Emit const readonly fields as types (#24288) (camc314) - 40f769d minifier: Make `__proto__` write tracking execution-order independent (#24280) (Dunqing) - 6371fed transformer: Remove stale enum member bindings (#24272) (camc314) - f05dfab transformer: Correct symbol flags for lowered namespaces (#24271) (Dunqing) - 84eeb55 transformer: Correct symbol flags for lowered enums (#24269) (Dunqing) - c3057da transformer: Preserve generated class binding spans (#24220) (camc314) - 8260096 transformer: Correct span for lowered namespace symbol (#24222) (camc314) - 42d00d3 semantic: Mark declared class heritage as type references (#24237) (camc314) - 588d997 semantic: Mark TS `PropertyDefinition`s computed fields as type references (#24233) (camc314) - 9b95632 semantic: Mark computed method keys in `TSMethodSignature`s as type references (#24232) (camc314) ### ⚡ Performance - 5b26643 transformer_plugins: Dispatch global defines by trailing name (#23666) (Boshen) - dce0f29 react_compiler: Replace all compiled functions in a single AST walk (#24403) (Boshen) - f85f0d8 ast: Delegate inherited enum variants in clone_in and estree derives (#23555) (Boshen) - 3ff0234 allocator: Remove `unwrap` from `ReplaceWith` (#24365) (overlookmotel) - ab22e80 transformer: Fix Rust 1.97 performance regression (#24354) (camc314) - b47585c parser: Use `ReplaceWith` instead of `TakeIn` (#24018) (overlookmotel) - b227a06 minifier: Use `ReplaceWith` instead of `TakeIn` (#24017) (overlookmotel) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Span { start: 0, end: 0 }mismatches