Skip to content

fix(react_compiler): normalize snapshot fixture paths#24142

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-react-compiler-windows-snapshots
Jul 4, 2026
Merged

fix(react_compiler): normalize snapshot fixture paths#24142
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-react-compiler-windows-snapshots

Conversation

@camc314

@camc314 camc314 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Normalize React compiler snapshot names using path components instead of splitting on /fixtures/.
  • Normalize fixture source newlines before parsing so diagnostic byte offsets are stable across Windows and Unix checkouts.
  • Allow manually dispatched CI runs to execute the Windows cargo test job, without enabling it for normal pull requests.

Root Cause

Windows insta::glob! passes fixture paths like \?\E:\oxc\crates\oxc_react_compiler\fixtures\.... The old string split only handled Unix /fixtures/, so Windows generated absolute-path snapshot names and treated every fixture as a new snapshot. After fixing that, Windows still differed because CRLF fixture checkout shifted diagnostic source offsets relative to LF snapshots.

@codspeed-hq

codspeed-hq Bot commented Jul 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 14 skipped benchmarks1


Comparing codex/fix-react-compiler-windows-snapshots (d044744) with main (4b16e1a)2

Open in CodSpeed

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (5bd3f28) during the generation of this report, so 4b16e1a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314
camc314 marked this pull request as ready for review July 3, 2026 23:48
Copilot AI review requested due to automatic review settings July 3, 2026 23:48
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 3, 2026

camc314 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 3, 11:49 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 3, 11:51 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jul 3, 11:55 PM UTC: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (All comments in this PR must be resolved before merging. Once you've resolved all open comment threads, you can retry your merge.).
  • Jul 3, 11:56 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 3, 11:56 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jul 4, 8:32 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 4, 8:32 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jul 4, 8:38 AM UTC: Merged by the Graphite merge queue.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves cross-platform determinism for oxc_react_compiler snapshot tests by making snapshot naming and diagnostic offsets stable across Windows and Unix checkouts.

Changes:

  • Normalize snapshot names using Path components (instead of string-splitting on "/fixtures/") so Windows paths don’t produce absolute-path snapshot IDs.
  • Normalize fixture source newlines to \n before parsing to keep diagnostic byte offsets consistent across CRLF/LF checkouts.
  • Add cow-utils as a dev-dependency to support efficient copy-on-write newline normalization.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_react_compiler/tests/snapshot.rs Normalizes newlines before parsing and derives snapshot names from path components for OS-independent snapshot IDs.
crates/oxc_react_compiler/Cargo.toml Adds cow-utils under dev-dependencies for newline normalization in snapshot tests.
Cargo.lock Updates lockfile to include cow-utils in the react compiler test dependency set.

Comment thread crates/oxc_react_compiler/tests/snapshot.rs
graphite-app Bot pushed a commit that referenced this pull request Jul 3, 2026
## Summary

- Normalize React compiler snapshot names using path components instead of splitting on `/fixtures/`.
- Normalize fixture source newlines before parsing so diagnostic byte offsets are stable across Windows and Unix checkouts.
- Allow manually dispatched CI runs to execute the Windows cargo test job, without enabling it for normal pull requests.

## Root Cause

Windows `insta::glob!` passes fixture paths like `\?\E:\oxc\crates\oxc_react_compiler\fixtures\...`. The old string split only handled Unix `/fixtures/`, so Windows generated absolute-path snapshot names and treated every fixture as a new snapshot. After fixing that, Windows still differed because CRLF fixture checkout shifted diagnostic source offsets relative to LF snapshots.
@graphite-app
graphite-app Bot force-pushed the codex/fix-react-compiler-windows-snapshots branch from d044744 to 4b187f5 Compare July 3, 2026 23:51
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 3, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 4, 2026
## Summary

- Normalize React compiler snapshot names using path components instead of splitting on `/fixtures/`.
- Normalize fixture source newlines before parsing so diagnostic byte offsets are stable across Windows and Unix checkouts.
- Allow manually dispatched CI runs to execute the Windows cargo test job, without enabling it for normal pull requests.

## Root Cause

Windows `insta::glob!` passes fixture paths like `\?\E:\oxc\crates\oxc_react_compiler\fixtures\...`. The old string split only handled Unix `/fixtures/`, so Windows generated absolute-path snapshot names and treated every fixture as a new snapshot. After fixing that, Windows still differed because CRLF fixture checkout shifted diagnostic source offsets relative to LF snapshots.
@graphite-app
graphite-app Bot force-pushed the codex/fix-react-compiler-windows-snapshots branch from 4b187f5 to 09c8f59 Compare July 4, 2026 08:33
@graphite-app
graphite-app Bot merged commit 09c8f59 into main Jul 4, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 4, 2026
@graphite-app
graphite-app Bot deleted the codex/fix-react-compiler-windows-snapshots branch July 4, 2026 08:38
Boshen added a commit that referenced this pull request Jul 6, 2026
### 🚀 Features

- 260425f semantic/examples: Include unresolved references (#24214)
(camc314)
- 2d9b0b3 minifier: Fold boolean-literal ternary branches in value
contexts (#24110) (Dunqing)
- 61fbf10 ast: Implement `ReplaceWith` on all AST types (#24013)
(overlookmotel)
- 7db7a29 allocator: Add `ReplaceWith` trait (#24012) (overlookmotel)
- 4eb074e mangler: Add `reserved` option for names that must not be
mangled (#24041) (Dunqing)
- 2e62012 data_structures: Add `StringExt` trait (#24006)
(overlookmotel)
- 60e7160 minifier: Drop side-effect-free IIFEs whose result is unused
(#23967) (Dunqing)
- 26dd9e2 ast: Add method to widen inherited enum ref to parent ref
(#23961) (overlookmotel)

### 🐛 Bug Fixes

- e8b50ee transformer: Clean up semantics for stripped TypeScript syntax
(#24180) (camc314)
- d966d0b react_compiler: Remove clippy allows (#24168) (Boshen)
- 854ef8d react_compiler: Compile generic functions instead of
over-bailing on type-param hoisting (#24158) (Boshen)
- 093586c react_compiler: Align memoization cache-slot allocation with
Babel (#24157) (Boshen)
- 09c8f59 react_compiler: Normalize snapshot fixture paths (#24142)
(camc314)
- f13df97 react_compiler: Drop stray empty statement from catch bindings
(#24133) (Boshen)
- cb2a505 react_compiler: Codegen destructuring reassignment targets
(#24131) (Boshen)
- b82c394 react_compiler: Propagate codegen invariants instead of
emitting empty bodies (#24128) (Boshen)
- 5771982 react_compiler: Render unchanged programs as source in fixture
snapshots (#24129) (Boshen)
- 4b16e1a transformer/async-to-generator: Preserve direct eval scope
flags (#24136) (camc314)
- 4e9194f react_compiler: Lower `delete obj.prop` to
Property/ComputedDelete (#24123) (Boshen)
- 0b25582 ast: Type binding node `typeAnnotation` as `TSTypeAnnotation |
null` (#23113) (Boshen)
- 018c0e5 transformer: Hoist lowered async declarations (#22770)
(camc314)
- 652fbaf mangler: Keep names of destructured exported bindings (#24036)
(Dunqing)
- e274415 minifier: Don't drop global calls that throw despite pure
arguments (#23917) (Dunqing)
- 59abb30 minifier: Only merge string literals in `try_fold_add` when
the inner operator is `+` (#23622) (Jerry Zhao)

### ⚡ Performance

- c5ca77b transformer: Avoid cloning refresh options (#24191) (camc314)
- bf1a151 react_compiler: Compile out debug printers (#24184) (Boshen)
- abb44a0 transformer: Build fixed object-rest arguments (#24190)
(camc314)
- a4db731 isolated_declarations: Use `ReplaceWith` instead of `TakeIn`
(#24016) (overlookmotel)
- ff10855 transformer: Use `ReplaceWith` instead of `TakeIn` (#24015)
(overlookmotel)
- bd49aff ecmascript: Avoid heap-allocating Math.min/max/imul operands
(#23941) (Lawrence Lin)
- e4b708b react_compiler: Skip compiled files before prefilters (#24171)
(Boshen)
- c59f2fe rust: Return impl ExactSizeIterator from slice-backed
accessors (#24144) (Boshen)
- 5d6d04a codegen: SWAR-skip boring byte runs in sourcemap line/column
scan (#24023) (Boshen)
- a55e0be traverse: Reduce string operations in `get_var_name_from_node`
(#24007) (overlookmotel)
- e6d48e1 transformer/nullish_coalescing: Move cold path into separate
function (#23989) (overlookmotel)
- c4e35b5 transformer/object_rest_spread: Pre-allocate capacity in `Vec`
(#23988) (overlookmotel)
- 527b8e5 transformer/decorators: Narrow type earlier (#23987)
(overlookmotel)

### 📚 Documentation

- 30d17f5 allocator: Clarify docs for `TakeIn::take_in_box` (#24093)
(overlookmotel)
- 675e6a8 ast: Correct doc comment for `PrivateFieldExpression` (#24008)
(overlookmotel)
- e4c30e6 minifier: Explain what `dce` mode means (#23994) (Dunqing)
- 37cbf88 ast_macros: Document fields of `StructDetails` (#23959)
(overlookmotel)
- 4de3e54 ast: Correct doc comment (#23948) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants